[Rt-commit] rt branch 5.0/search-filter-scrollable created. rt-5.0.3-346-g21658ea4cd

BPS Git Server git at git.bestpractical.com
Fri Mar 31 13:33:38 UTC 2023


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rt".

The branch, 5.0/search-filter-scrollable has been created
        at  21658ea4cd9a1901cacd33076c94354b05758ac6 (commit)

- Log -----------------------------------------------------------------
commit 21658ea4cd9a1901cacd33076c94354b05758ac6
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Mar 31 04:33:41 2023 +0800

    Increase queue limit to 100 in search filter as the modal is now scrollable

diff --git a/share/html/Elements/SearchFilter b/share/html/Elements/SearchFilter
index bf3867c06d..cea3f774c9 100644
--- a/share/html/Elements/SearchFilter
+++ b/share/html/Elements/SearchFilter
@@ -375,7 +375,7 @@ if ( !$cached ) {
 
         while ( my $queue = $queues->Next ) {
             push @queues, $queue;
-            last if @queues == 10;    # TODO make a config for it
+            last if @queues == 100;    # TODO make a config for it
         }
     }
 

commit 33d598cd9930488a2ec3ecf806e60d9784930e48
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Mar 31 04:30:33 2023 +0800

    Make search filter modal body scrollable in case of long content
    
    As these modals are set to "position: absolute", they are not scrollable
    by default, we need to use this alternative scroll mechanism.

diff --git a/share/html/Elements/SearchFilter b/share/html/Elements/SearchFilter
index 21fe0630b3..bf3867c06d 100644
--- a/share/html/Elements/SearchFilter
+++ b/share/html/Elements/SearchFilter
@@ -46,7 +46,7 @@
 %#
 %# END BPS TAGGED BLOCK }}}
 <div class="modal search-results-filter">
-  <div class="modal-dialog <% $modal_class %>" role="document">
+  <div class="modal-dialog modal-dialog-scrollable <% $modal_class %>" role="document">
     <form name="search-results-filter">
       <div class="modal-content">
         <div class="modal-header">

-----------------------------------------------------------------------


hooks/post-receive
-- 
rt


More information about the rt-commit mailing list