[rt-devel] RT 1.3.59 - Eve-before-beta

[ivan]

On Wed, Mar 21, 2001 at 04:19:38PM +0000, Kevin Croombs wrote:

> I have a scrip configured - "OnComment NotifyAdminWatchersAsComment
> with template AdminComment".  This appears to work - admin watchers
> are notified, but the email has "From:" set to the correspondence
> address rather than the comment address.  Is this a bug?

Yes, I was recently bitten by this.  Here's a fix:

ivan at rootwood:~/RT/work/rt$ cvs diff -u -r1.1
lib/RT/Action/NotifyAsComment.pm 
Index: lib/RT/Action/NotifyAsComment.pm
===================================================================
RCS file: /proj/maps/cvsroot/rt/lib/RT/Action/NotifyAsComment.pm,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- lib/RT/Action/NotifyAsComment.pm    2000/12/19 00:58:37     1.1
+++ lib/RT/Action/NotifyAsComment.pm    2001/03/20 15:02:46     1.2
@@ -2,5 +2,11 @@
 require RT::Action::Notify;
 @ISA = qw(RT::Action::Notify);
 
+sub _Init {
+  my $self = shift;
+  $self->{'comment'} = 1;
+  $self->SUPER::_Init(@_);
+}
+
 1;
 
> I would expect the "AsComment" actions to have from set to the comment
> address.

As did I...

-- 
meow
_ivan