[rt-devel] RT2 bugs and comments
Arthur de Jong
arthur at West.NL
Tue Mar 27 03:46:06 EST 2001
> > First of all my Date patch didn't get through quite right. The patch for
> > editing dates was against two files and only one got partly through
> > resulting in wrong output. My Elements/SelectDate and
> > Ticket/Elements/EditDates files are attached.
> Actually, your original patch worked in a way that wasn't quite how
> I wanted to make it work. The "fill in date" boxes should be blank,
> rather than containing the existing date, because, in general, it's going
> to be harder for a user to enter a new date. (The range of acceptable
> dates that can be entered is very very wide. you don't have to keep things in
> ISO format. Try typing "next tuesday" into a date selector).
There is also a patch in there that fixes a nasty bug (but if the code isn't used
it does not show). The month was incremented twice and the year was added 1900
twice.
> > I modified several files (Ticket/Elements/EditPeople,
> > Ticket/Elements/EditWatchers, Ticket/Elements/ShowPeople and
> > Ticket/Update.html) to show the Cc's and AdminCc's for the queue alongside
> > the list of Cc's and AdminCc's for the ticket. I did a grep on all the
> > files and I think these are all the files displaying this info. See
> > attached files for my version of the file.
> I'll probably take a variant of this into the core release. I want
> to make sure that queue and ticket watchers are kept very seperate
> and that people always understand who is what sort of watcher.
> But I appreciate the need to better inform the user about queue watchers.
The edit people link shows the different watchers in the following groups:
Requestors, Cc, Administrative Cc, Queue Cc and Queue Admin Cc. The last two are
not deletable in the screen. On all the other screens (where CC and Admin CC are
just listed) no distinction is made. You could always show Queue watchers in a
different color (not shure that would make things clearer though).
> While I'd rather have a "jumbo" patch than no patch at all, if you're able
> to do seperate patches for each feature, that would be even cooler. Sometimes,
> different features have different priorities for getting into the codebase and
> it's helpful to be able to pull in the really high-priority stuff right away.
Ok two features (date stuff and queue watchers stuff) in two patches (dates.patch
and watchers.patch).
-- arthur de jong - arthur at west.nl - west consulting b.v. --
-------------- next part --------------
diff -Naur WebRT.1-3-62/html/Elements/SelectDate WebRT/html/Elements/SelectDate
--- WebRT.1-3-62/html/Elements/SelectDate Mon Mar 26 11:49:55 2001
+++ WebRT/html/Elements/SelectDate Mon Mar 26 12:15:53 2001
@@ -5,8 +5,6 @@
($current <= 0)) {
my ($sec,$min,$hour,$mday,$mon,$year,$wday,$yday,$isdst) =
localtime($current);
- $mon++;
- $year+=1900;
$Default = sprintf("%04d-%02d-%02d %02d:%02d",
$year+1900,$mon+1,$mday,
diff -Naur WebRT.1-3-62/html/Ticket/Elements/EditDates WebRT/html/Ticket/Elements/EditDates
--- WebRT.1-3-62/html/Ticket/Elements/EditDates Mon Mar 26 11:50:00 2001
+++ WebRT/html/Ticket/Elements/EditDates Mon Mar 26 12:11:10 2001
@@ -3,7 +3,7 @@
Starts:
</TD>
<TD>
-<& /Elements/SelectDate, menu_prefix => 'Starts', current => 0 &>
+<& /Elements/SelectDate, menu_prefix => 'Starts', current => $TicketObj->StartsObj->Unix &>
(<% $TicketObj->StartsObj->AsString %>)
</TD>
</TR>
@@ -12,7 +12,8 @@
Started:
</TD>
<TD>
-<& /Elements/SelectDate, menu_prefix => 'Started', current => 0 &> (<%$TicketObj->StartedObj->AsString %>)
+<& /Elements/SelectDate, menu_prefix => 'Started', current => $TicketObj->StartedObj->Unix &>
+ (<%$TicketObj->StartedObj->AsString %>)
@@ -24,7 +25,8 @@
Last Contact:
</TD>
<TD>
-<& /Elements/SelectDate, menu_prefix => 'Told', current => 0 &> (<% $TicketObj->ToldObj->AsString %>)
+<& /Elements/SelectDate, menu_prefix => 'Told', current => $TicketObj->ToldObj->Unix &>
+ (<% $TicketObj->ToldObj->AsString %>)
</TD>
</TR>
@@ -34,7 +36,8 @@
</TD>
<TD>
-<& /Elements/SelectDate, menu_prefix => 'Due', current => 0 &> (<% $TicketObj->DueObj->AsString %>)
+<& /Elements/SelectDate, menu_prefix => 'Due', current => $TicketObj->DueObj->Unix &>
+ (<% $TicketObj->DueObj->AsString %>)
</TD>
</TR>
-------------- next part --------------
diff -Naur WebRT.1-3-62/html/Ticket/Elements/EditPeople WebRT/html/Ticket/Elements/EditPeople
--- WebRT.1-3-62/html/Ticket/Elements/EditPeople Mon Mar 26 11:50:01 2001
+++ WebRT/html/Ticket/Elements/EditPeople Mon Mar 26 14:13:56 2001
@@ -25,6 +25,12 @@
Administrative Cc:
<& EditWatchers, TicketObj => $Ticket, Type => 'admincc' &>
+Queue Cc:
+<& EditWatchers, TicketObj => $Ticket, Type => 'queuecc' &>
+
+Queue Admin Cc:
+<& EditWatchers, TicketObj => $Ticket, Type => 'queueadmincc' &>
+
</TD>
</TR>
</TABLE>
@@ -34,4 +40,4 @@
$UserOp => undef
$UserString => undef
$Ticket => undef
-</%ARGS>
\ No newline at end of file
+</%ARGS>
diff -Naur WebRT.1-3-62/html/Ticket/Elements/EditWatchers WebRT/html/Ticket/Elements/EditWatchers
--- WebRT.1-3-62/html/Ticket/Elements/EditWatchers Mon Mar 26 11:50:00 2001
+++ WebRT/html/Ticket/Elements/EditWatchers Mon Mar 26 16:03:10 2001
@@ -11,7 +11,9 @@
%while (my $watcher=$watchers->Next) {
<li>
+%if ($deletable) {
<INPUT TYPE=CHECKBOX NAME="DelWatcher<%$watcher->id%>" UNCHECKED>
+%}
%#If there's a principal backing this user, lets give a link to their
%# account
%if ($watcher->IsUser) {
@@ -24,16 +26,25 @@
%}
</ul>
<%INIT>
-my ($watchers, $watcher, $set);
+my ($watchers, $watcher, $set, $deletable);
+$deletable = 1;
if ($Type =~ /^request/i) {
$watchers = $TicketObj->Requestors;
}
-elsif ($Type =~ /^admin/i) {
+elsif ($Type =~ /^admincc/i) {
$watchers = $TicketObj->AdminCc;
}
elsif ($Type =~ /^cc/i) {
$watchers = $TicketObj->Cc;
}
+elsif ($Type =~ /^queueadmincc/i) {
+ $watchers = $TicketObj->QueueObj->AdminCc;
+ $deletable = 0;
+ }
+elsif ($Type =~ /^queuecc/i) {
+ $watchers = $TicketObj->QueueObj->Cc;
+ $deletable = 0;
+ }
else { $watchers = $TicketObj->Watchers;
}
</%INIT>
@@ -41,6 +52,3 @@
$TicketObj => undef
$Type => undef
</%ARGS>
-
-
-
diff -Naur WebRT.1-3-62/html/Ticket/Elements/ShowPeople WebRT/html/Ticket/Elements/ShowPeople
--- WebRT.1-3-62/html/Ticket/Elements/ShowPeople Mon Mar 26 11:50:01 2001
+++ WebRT/html/Ticket/Elements/ShowPeople Mon Mar 26 17:03:28 2001
@@ -3,9 +3,9 @@
Requestors<BR>
<B><%$Ticket->RequestorsAsString%></B><BR>
Cc<BR>
- <B><%$Ticket->CcAsString%></B><BR>
+ <B><% join(", ",@{$Ticket->Cc->Emails},@{$Ticket->QueueObj->Cc->Emails}) %></B><BR>
AdminCc<BR>
- <B><%$Ticket->AdminCcAsString%></B>
+ <B><% join(", ",@{$Ticket->AdminCc->Emails},@{$Ticket->QueueObj->AdminCc->Emails}) %></B>
<%ARGS>
$Ticket => undef
</%ARGS>
diff -Naur WebRT.1-3-62/html/Ticket/Update.html WebRT/html/Ticket/Update.html
--- WebRT.1-3-62/html/Ticket/Update.html Mon Mar 26 11:49:59 2001
+++ WebRT/html/Ticket/Update.html Mon Mar 26 17:08:53 2001
@@ -12,8 +12,8 @@
<TD>
<ul>
<li> Requestor: <% $Ticket->RequestorsAsString %>
-<li> Cc: <% $Ticket->CcAsString %>
-<li> AdminCc: <% $Ticket->AdminCcAsString %>
+<li> Cc: <% join(", ",@{$Ticket->Cc->Emails},@{$Ticket->QueueObj->Cc->Emails}) %>
+<li> AdminCc: <% join(", ",@{$Ticket->AdminCc->Emails},@{$Ticket->QueueObj->AdminCc->Emails}) %>
</ul>
</TD>
</TR>
More information about the Rt-devel
mailing list