[rt-devel] RT::Action::Autoreply derive from RT::Action::Notify?
jesse at bestpractical.com
Wed Feb 20 00:22:55 EST 2002
I should also point out that by default, Notify strips the sender out of the
message's recipients. The whole reason Autoreply was created as a seperate
module was to avoid that behavior.
On Tue, Feb 19, 2002 at 11:58:02PM -0500, Jesse Vincent wrote:
> Autoreply is a one-trick pony. What do you stand to gain by adding
> the layer of indirection?
> On Tue, Feb 19, 2002 at 08:51:45PM -0800, Jim Meyer wrote:
> > Howdy!
> > The subject mostly says it all.
> > RT::Action::Autoreply derives from RT::Action::SendEmail, in which
> > SetRecipients() is a mostly empty placeholder waiting to be overridden.
> > As you might expect, RT:A:AR overrides it by forcing the requestors into
> > the To field and moving on.
> > Contrast this with RT::Action::Notify, which implements a lovely
> > SetRecipients() accepting as an argument a comma-separated list any or
> > all of "Owner, Requestor, AdminCc, Cc or All". This allows RT:A:N to be
> > used all the different non-"AsComment" scrips just by changing the
> > arguments.
> > It feels like Autoreply should either derive from Notify (as
> > NotifyAsComment does) or Notify::SetRecipients() should be promoted to
> > SendEmail. Oddly enough, I favor the latter because an autoreply is just
> > a specialized notification (with the proper queue return address set).
> > Any thoughts? I'll happily submit either patch.
> > Thanks!
> > --j
> > --
> > Jim Meyer, Geek At Large purp at wildbrain.com
> > _______________________________________________
> > rt-devel mailing list
> > rt-devel at lists.fsck.com
> > http://lists.fsck.com/mailman/listinfo/rt-devel
> http://www.bestpractical.com/products/rt -- Trouble Ticketing. Free.
> rt-devel mailing list
> rt-devel at lists.fsck.com
http://www.bestpractical.com/products/rt -- Trouble Ticketing. Free.
More information about the Rt-devel