[rt-devel] Re: [PATCH] Transaction template has bad subject

[Blair Zajac]

OK, here is is with the patch.

Blair Zajac wrote:
> 
> In RT 2.0.11, the default Transaction template subject ends up looking like
> this in email:
> 
>      Subject: HASH(0x8e7c758)
> 
> I believe the line
> 
>         {$Transaction->Subject || {$Ticket->Subject} || "(No subject given)"
> 
> should be
> 
>         {$Transaction->Subject || $Ticket->Subject || "(No subject given)"
> 
> The attached patch fixes this.
> 
> It also cleans up the AutoReply template to remove tabs from the email and
> replace them with 8 spaces.  I also lines up the indented lines to make the
> response message look a little cleaner.  Finally, it changes some spaces to
> tabs to be consistent with other Perl code.
> 
> Best,
> Blair
> 
> --
> Blair Zajac <blair at orcaware.com>
> Web and OS performance plots - http://www.orcaware.com/orca/

-- 
Blair Zajac <blair at orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
-------------- next part --------------
--- insertdata.orig	Mon Dec 17 11:58:53 2001
+++ insertdata	Wed Jan  9 11:46:42 2002
@@ -290,25 +290,27 @@
 # {{{ Templates
 my @templates = (
 {
-                Queue   => '0',
-                Name => 'Autoreply',
-				Description => 'Default Autoresponse Template', 
-				Content => 
+		Queue => '0',
+		Name => 'Autoreply',
+		Description => 'Default Autoresponse Template', 
+		Content => 
 'Subject: AutoReply: {$Ticket->Subject}
 
+Greetings,
 
-       Greetings,
-        This message has been automatically generated in response to the
+This message has been automatically generated in response to the
 creation of a trouble ticket regarding:
-	"{$Ticket->Subject()}", 
+
+        "{$Ticket->Subject()}", 
+
 a summary of which appears below.
 
-There is no need to reply to this message right now.  Your ticket has been
-assigned an ID of [{$rtname} #{$Ticket->id()}].
+There is no need to reply to this message right now.  Your ticket
+has been assigned an ID of [{$rtname} #{$Ticket->id()}].
 
 Please include the string:
 
-         [{$rtname} #{$Ticket->id}]
+        [{$rtname} #{$Ticket->id}]
 
 in the subject line of all future correspondence about this issue. To do so, 
 you may reply to this message.
@@ -331,7 +333,7 @@
 {$Transaction->CreatedAsString}: Request {$Ticket->id} was acted upon.
 Transaction: {$Transaction->Description}
        Queue: {$Ticket->QueueObj->Name}
-     Subject: {$Transaction->Subject || {$Ticket->Subject} || "(No subject given)"}
+     Subject: {$Transaction->Subject || $Ticket->Subject || "(No subject given)"}
        Owner: {$Ticket->OwnerObj->Name}
   Requestors: {$Ticket->Requestors->EmailsAsString()}
       Status: {$Ticket->Status}