[rt-devel] Re: [PATCH] Preserve original charset + fix bogus UTF32LE guess on binary attachments

[Dmitry Sivachenko]

On Sat, Jun 28, 2003 at 01:39:00AM +0800, Autrijus Tang wrote:
> On Fri, Jun 27, 2003 at 06:36:15PM +0400, Dmitry Sivachenko wrote:
> > > [Fri Jun 27 12:51:17 2003] [debug]: Detecting charset for: Return-Path: <mitya at v
> > > h.demos.su>
> > > It looks like RT should not try to GUESS charset for elements which directly 
> > > specify it (like in Subject above).
> 
> This is not something to worry about at all.  "Detecting" including
> using the explicit info.  It's not "guessing".

Well, I was talking about _GuessCharset subroutine, which only *guesses*
charset via Encode::Guess.  I see no reason to guess something in
http://mitya.pp.ru/rt-bad , because all non-ascii characters it in are
properly encoded.
Probably I am missing something.

> 
> > Content-Type: application/octet-stream;
> <snip>
> > Thus filename is in UTF without encoding specification.
> 
> Now _that_ is the problem because MUAs may not support raw UTF8
> filenames.
> 
> Can you try the following patch against RT::Action::SendEmail
> and see if it works?

Yes, not filename of the attachment is properly encoded, thanks!