[Rt-devel] Bug in RT3.0.11 RT::Ticket::SetStatus

[Stephen Quinney]

On Thu, Dec 02, 2004 at 03:02:09PM -0500, Jesse Vincent wrote: 
> On Thu, Dec 02, 2004 at 04:47:53PM +0000, Stephen Quinney wrote:
> > On Thu, Dec 02, 2004 at 02:30:54PM +0100, Ruediger Riediger wrote:
> > > Looks like there is a misspelled status name in lib/RT/Ticket_Overlay.pm
> > > 
> > > 3317c3317
> > > <     if ( $args{Status} =~ /^(resolved|rejected|dead)$/ ) {
> > > ---
> > > >     if ( $args{Status} =~ /^(resolved|rejected|deleted)$/ ) {
> > 
> > This bug is also present in the same file in RT 3.2.2.
> 
> Yep. and actually, it should be using $self->QueueObj->IsInactiveStatus.
> Anyone want to hand me a patch while I'm off debugging issues with the
> latest DBD::Oracle and MIME::Tools?
> 

Here's a patch which should do the correct thing for 3.0.12:

########
--- request-tracker3-3.0.12.orig/lib/RT/Ticket_Overlay.pm
+++ request-tracker3-3.0.12/lib/RT/Ticket_Overlay.pm
@@ -3314,7 +3314,7 @@
                      RecordTransaction => 0 );
     }
 
-    if ( $args{Status} =~ /^(resolved|rejected|dead)$/ ) {
+    if ( $self->QueueObj->IsInactiveStatus($args{Status}) ) {
 
         #When we resolve a ticket, set the 'Resolved' attribute to now.
         $self->_Set( Field             => 'Resolved',
########

Here's a patch for 3.2.2:

########
--- request-tracker3.2-3.2.2.orig/lib/RT/Ticket_Overlay.pm
+++ request-tracker3.2-3.2.2/lib/RT/Ticket_Overlay.pm
@@ -3191,7 +3191,7 @@
                      RecordTransaction => 0 );
     }
 
-    if ( $args{Status} =~ /^(resolved|rejected|dead)$/ ) {
+    if ( $self->QueueObj->IsInactiveStatus($args{Status}) ) {
 
         #When we resolve a ticket, set the 'Resolved' attribute to now.
         $self->_Set( Field             => 'Resolved',
########


I will apply the patch to the 3.0.12 request-tracker3 package in
Debian shortly to make sure the fix gets into sarge.

Stephen Quinney

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.bestpractical.com/pipermail/rt-devel/attachments/20041203/66a72109/attachment.pgp