[Rt-devel] RT 3.0.11 Release Canddiate 1

[Jesse Vincent]

Thanks. applied


On Thu, May 06, 2004 at 04:51:04PM +0400, Ruslan U. Zakirov wrote:
> I vote for rc2 :) At least one patch must be in 3.0.11
> 
> patches attached
> 
> one showstoper: Cc, AdminCc search doesn't work.
> 
> long standing bug with log to file:
> 1) If file name absolute RT still check permissions on RT::LogToDir.
> 2) RT should check file existance and write right on it befor check dir 
> for write access.
> 
> and last one is minor UI fix.
> RT displays queue id in tabs when user edit queue specific scrip.
> 
> all patches tested.
> 
> 			Best regards. Ruslan.
> 
> 
> Jesse Vincent wrote:
> 
> >RT 3.0.11rc1 is now available from:
> >
> >http://download.bestpractical.com/pub/rt/devel/rt-3.0.11rc1.tar.gz
> >	    (623784ee7aa49bc1890ae386aa4a3648  rt-3.0.11rc1.tar.gz)
> >
> >An annotated and sumamrized changelog is forthcoming. As long as no
> >showstoppers are found, I expect to release 3.0.11 next week unless
> >there's a showstopper.  Additionally, I expect RT 3.1.x to freeze for
> >translation in the next week or so. At that time, I'll roll another beta
> >release and make existing and new translations avialable for update. At
> >this point, we're feature complete and running in production on
> >rt3.fsck.com. 
> >
> >	Best,
> >	Jesse

> === lib/RT/Tickets_Overlay.pm
> ==================================================================
> --- lib/RT/Tickets_Overlay.pm  (revision 540)
> +++ lib/RT/Tickets_Overlay.pm  (revision 541)
> @@ -101,8 +101,8 @@
>      Filename        => ['TRANSFIELD',],
>      TransactionDate => ['TRANSDATE',],
>      Requestor       => ['WATCHERFIELD' => 'Requestor',],
> -    CC              => ['WATCHERFIELD' => 'Cc',],
> -    AdminCC         => ['WATCHERFIELD' => 'AdminCC',],
> +    Cc              => ['WATCHERFIELD' => 'Cc',],
> +    AdminCc         => ['WATCHERFIELD' => 'AdminCC',],
>      Watcher	    => ['WATCHERFIELD'],
>      LinkedTo	    => ['LINKFIELD',],
>      CustomFieldValue =>['CUSTOMFIELD',],

> === html/Admin/Queues/Scrip.html
> ==================================================================
> --- html/Admin/Queues/Scrip.html  (revision 539)
> +++ html/Admin/Queues/Scrip.html  (revision 540)
> @@ -51,7 +51,7 @@
>  if ($id) {
>      $current_subtab = "Admin/Queues/Scrip.html?id=".$id."&Queue=".$QueueObj->id;
>      $title = loc("Modify a scrip for queue [_1]", $QueueObj->Name);
> -    $subtabs->{"C"} = { title => loc("Scrip #[_1]",$QueueObj->id),
> +    $subtabs->{"C"} = { title => loc("Scrip #[_1]",$id),
>  			path => "Admin/Queues/Scrip.html?id=$id&Queue=".$QueueObj->id };
>  } else {
>      $current_subtab = "Admin/Queues/Scrip.html?create=1&Queue=".$QueueObj->id;

> === lib/RT.pm.in
> ==================================================================
> --- lib/RT.pm.in  (revision 541)
> +++ lib/RT.pm.in  (revision 542)
> @@ -168,21 +168,23 @@
>      $RT::Logger=Log::Dispatch->new();
>      
>      if ($RT::LogToFile) {
> -
> -    unless (-d $RT::LogDir && -w $RT::LogDir) {
> -        # localizing here would be hard when we don't have a current user yet
> -        # die $self->loc("Log directory [_1] not found or couldn't be written.\n RT can't run.", $RT::LogDir);
> -        die ("Log directory $RT::LogDir not found or couldn't be written.\n RT can't run.");
> -    }
> -
> -	my $filename;
> +	my ($filename, $logdir);
>  	if ($RT::LogToFileNamed =~ m![/\\]!) {
>  	    # looks like an absolute path.
>  	    $filename = $RT::LogToFileNamed;
> +	    ($logdir) = $RT::LogToFileNamed =~ m!^(.*[/\\])!;
>  	}
>  	else {
>  	    $filename = "$RT::LogDir/$RT::LogToFileNamed";
> +	    $logdir = $RT::LogDir;
>  	}
> +
> +    unless ( -d $logdir && ( ( -f $filename && -w $filename ) || -w $logdir ) ) {
> +        # localizing here would be hard when we don't have a current user yet
> +        # die $self->loc("Log directory [_1] not found or couldn't be written.\n RT can't run.", $RT::LogDir);
> +        die ("Log file $filename couldn't be written or created.\n RT can't run.");
> +    }
> +
>      require Log::Dispatch::File;
>  
>  


--