[Rt-devel] [PATCH] TnxBatch stage vs ApplicableTransTypes

[Ruslan U. Zakirov]

		Hello.

History:
<ruz> FYI if ScripCondition has ApplicableTransTypes is not 'Any' then 
scrips with this condition would be skipped in TxnBatch stage
<autrijus> this is a good thing or a bad thing?
<ruz> bad :( you can't use standard conditions easy, like 'On Resolve'. 
Yesterday, tried to write good resolve template that adds right 
resolution comment(not last but that was posted exactly with resolve) if 
TxnBatch enabled. Now, should use custom condition too. 
ApplicableTransTypes useless restriction that breaks flexibility
<autrijus> got it.
<autrijus> you think it's sensible to fix TxnBatch?
<ruz> should be deprecated or TxnBatch need another fix.
<autrijus> ApplicableTransTypes should be deprecated you mean?
<ruz> yes
<ruz> Each that condition anyway check type of transaction, but ofcause 
some users may have 10k of conditions :( so it would be perfomance penalty.
<autrijus> indeed.
<ruz> ok, then scrips need another one refactoring, we should select 
scrips with conditions applicable to 'Any' and to all types of 
transactions in batch if it's TxnBatch stage.
<autrijus> yup.
<autrijus> that sounds sane

Fix summary:
Type argument now support comma separated list so in batch stage we 
could provide list.
API backward compatible.

					Best regards. Ruslan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: TxnBatch-ApplicableTransTypes.patch
Type: application/aegis-patch
Size: 3216 bytes
Desc: not available
Url : http://lists.bestpractical.com/pipermail/rt-devel/attachments/20041022/5df72a77/TxnBatch-ApplicableTransTypes.bin