[Rt-devel] ParseTicketId duplicated

Florian Weimer fw at deneb.enyo.de
Wed Feb 23 12:31:01 EST 2005

* Jesse Vincent:

> On Wed, Feb 23, 2005 at 04:25:03PM +0100, Florian Weimer wrote:
>> RT 3.4.1 contains two copies of ParseTicketId, one in
>> RT::EmailParser::ParseTicketId, and another one in
>> RT::Interface::Email::ParseTicketId.
>> Apart from some calling convention issue, they are identical.  Is this
>> code duplication really necessary?  This is a likely place of
>> customization, and it would be nice if I needn't apply patches to both
>> variants.
> No. One of them is supposed to have been removed. Off the top of my
> head, I don't recall which.

The version in RT::EmailParser is the older one.  I had to apply my
patch to RT::Interface::Email::ParseTicketId to enable it again
because RT::EmailParser::ParseTicketId is no longer called.  (However,
I'm not sure if it's really dead.)

More information about the Rt-devel mailing list