[Rt-devel] PATCH - History display & performance (ShowTransaction)

[Ruslan Zakirov]

On 11/29/05, Jesse Vincent <jesse at bestpractical.com> wrote:
>
>
>
> On Mon, Nov 28, 2005 at 05:35:15PM -0500, Stephen Turner wrote:
> >
> > Here's one more suggestion for speeding up the display of transactions. I
> > noticed that in Ticket/Elements/ShowTransaction, the link for displaying an
> > Email Record is formed by using $Transaction->Attachments->First to get the
> > attachment ID. This repeats the query to get the transaction attachments
> > for each transaction. But all the ticket's attachments have already been
> > cached up front for performance reasons, so this additional query isn't
> > necessary.
> >
> > I've attached a patch that gets the attachment ID from the cached list
> > instead of re-reading it from the database. RT 3.4.2.
> >
> > Please let me know if I've misunderstood this!
>
> Hm. Does that actually change what database queries are done?
IMHO this skip SELECT of the atachments for the EmailRecord transaction.

+1

>
>
> > Steve
> >
> >
> > Stephen Turner
> > Senior Programmer/Analyst - Client Support Services
> > MIT Information Services and Technology (IS&T)
> >
>
>
> > _______________________________________________
> > Rt-devel mailing list
> > Rt-devel at lists.bestpractical.com
> > http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel
>
>
> --
> _______________________________________________
> Rt-devel mailing list
> Rt-devel at lists.bestpractical.com
> http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel
>


--
Best regards, Ruslan.