[Rt-devel] Re: [Rt-commit] r4155 - in rt/branches/QUEBEC-EXPERIMENTAL: . lib/t/regression

[Jesse Vincent]

On Wed, Nov 30, 2005 at 11:30:37PM +0300, Ruslan Zakirov wrote:
> I think I had sent patch that covers this situation and do the right
> thing! You must check nulls, at least you should check that they are
> in results, because such test handles situations when we loose tickets
> without requestors.

Any guess on when, so we can dig it out and get it applied?




> On 11/30/05, alexmv at bestpractical.com <alexmv at bestpractical.com> wrote:
> > Author: alexmv
> > Date: Wed Nov 30 15:26:08 2005
> > New Revision: 4155
> >
> > Modified:
> >    rt/branches/QUEBEC-EXPERIMENTAL/   (props changed)
> >    rt/branches/QUEBEC-EXPERIMENTAL/lib/t/regression/20-sort-by-requestor.t
> > Log:
> >  r7395 at zoq-fot-pik:  chmrr | 2005-11-30 15:25:32 -0500
> >   * Sort by requestor tests fail on some database backends because they
> >  sort nulls differently than Perl does; only compare non-nulls
> >
> >
> > Modified: rt/branches/QUEBEC-EXPERIMENTAL/lib/t/regression/20-sort-by-requestor.t
> > ==============================================================================
> > --- rt/branches/QUEBEC-EXPERIMENTAL/lib/t/regression/20-sort-by-requestor.t     (original)
> > +++ rt/branches/QUEBEC-EXPERIMENTAL/lib/t/regression/20-sort-by-requestor.t     Wed Nov 30 15:26:08 2005
> > @@ -58,7 +58,7 @@
> >      my @mails;
> >      while (my $t = $tix->Next) { push @mails, $t->RequestorAddresses; }
> >      is(@mails, 6, "found six tickets");
> > -    is_deeply( \@mails, [ sort @mails ], "Addresses are sorted");
> > +    is_deeply( [grep {$_} @mails], [ sort grep {$_} @mails ], "Addresses are sorted (exclude nulls, which are db-dependant)");
> >  }
> >
> >  # vim:ft=perl:
> > _______________________________________________
> > Rt-commit mailing list
> > Rt-commit at lists.bestpractical.com
> > http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-commit
> >
> 
> 
> --
> Best regards, Ruslan.
> _______________________________________________
> Rt-devel mailing list
> Rt-devel at lists.bestpractical.com
> http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel
> 

--