[Rt-devel] PATCH: autohandler WebExt* attr handling fixes

Jesse Vincent jesse at bestpractical.com
Thu Mar 30 21:19:37 EST 2006

*bzzt* Illegal use of internals. 200 line penalty. (Also, this code
feels less readable to me. But it might be a lot better with only a very
little bit of feedback

+                # Fetch the core attrs, dropping any we want to ignore
+                my @core_attrs = grep {!/^${ignore_regex}$/}
+                  keys(%{$UserObj->_CoreAccessible});

On Thu, Mar 30, 2006 at 02:29:39PM -0800, Jim Meyer wrote:
> Hello!
> I saw a fixme in the code that seemed approachable, so I did. I have
> *zero* way to test this as I have no easy way to set up all the stuff
> to try single-signon. Still, seems like it should work and be a touch
> more efficient as it walks the list of attrs received from
> WebExternalAutoInfo() rather than the list of all possible attrs.
> Also, I left "PagerEmailAddress" in even though it's not represented
> anywhere else in the code ... just in case. It could be dropped just
> as easily.
> This patch is dependent on my earlier indentation patch
> (http://www.gossamer-threads.com/lists/rt/devel/54538#54538).
> Cheers!
> --j
> --
> Jim Meyer, Geek at Large                                    purp at acm.org

> _______________________________________________
> List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel
> Best Practical is hiring! Come hack Perl for us: http://bestpractical.com/about/jobs.html


More information about the Rt-devel mailing list