[Rt-devel] PATCH: autohandler WebExt* attr handling fixes

Jesse Vincent jesse at bestpractical.com
Fri Mar 31 01:12:43 EST 2006



> Would you accept a patch to RT::Record which adds
> AccessibleAttributes(), a function which consolidates the
> attribute-finding logic in _BuildTableAttributes() and isn't an
> internal? I'll throw in refactoring _BuildTableAttributes() for free
> (and reduce it to one "foreach my $attr ...", even =) and rebase that
> autohandler work on $UserObj->AccessibleAttributes() instead.

->ReadableAttributes and WritableAttributes are in there somewhere
already, iirc



> As to readability, I'm wide open to feedback. =]
> 
> Cheers!
> 
> --j
> 
> p.s. the previous patch also had a typo, calling for "$valid_attr"
> instead of "$valid_attrs". Sorry. =\
> --
> Jim Meyer, Geek at Large                                    purp at acm.org
> 

-- 


More information about the Rt-devel mailing list