[Rt-devel] Re: RT 3.6.1 Refactoring SelfService MyRequests

[der Mouse]

>>> Including [patches] inline lets mail clients do horrible things,
>>> like wordwrap them, breaking the patches ;)
>> Surely a better fix would be for you to switch to an MUA that
>> doesn't gratuitiously wordwrap mail?
> The problem is pretty clearly at Mailman or further down the line.

Eww.  I've now looked in a bit more detail, and it would appear there
are at least two problems involved.

The original patches, for example, began (in my mailbox, which has a
history of preserving messages exactly as received) with

> --- share/html/SelfService/Elements/MyRequests  2006-06-19 
> 18:44:04.000000000 -0400
> +++ local/html/SelfService/Elements/MyRequests  2006-10-30 
> 20:21:19.000000000 -0500

(which is four lines, and anyone who doesn't see it that way needs an
MUA fix, since this message is also not being marked wordwrappable).

But your quote of it says

> --- share/html/SelfService/index.html   2006-06-19 18:44:04.000000000
> -0400
> +++ local/html/SelfService/index.html   2006-10-30 20:15:53.000000000
> -0500

(again, four lines) which makes me think *your* MUA *re*wordwrapped it!
So I now suspect both you and the OP need MUA work.

> David's doing a good thing for everybody by creating patches.
> Getting the patches as attachments, rather than inline in the body
> makes the workflow for anyone applying them a _lot_ easier.

Well, not "anyone"; it wouldn't for me.  Extracting the attachments
from the message is a nontrivial (albeit relatively small) additional
bit of work.  (If they aren't encoded quoted-unprintable or base-64,
this isn't needed, but that isn't true nearly as often as I'd like, and
I'd need to check, also a small but nontrivial task.)

Not that my own experience should necessarily guide people creating
patches, of course, especially since I'm unlikely to be doing much with
patches coming across this list.  Just pointing out that your apparent
assumption that your "convenient" matches everyone else's is not really
valid....

/~\ The ASCII				der Mouse
\ / Ribbon Campaign
 X  Against HTML	       mouse at rodents.montreal.qc.ca
/ \ Email!	     7D C8 61 52 5D E7 2D 39  4E F1 31 3E E8 B3 27 4B