[Rt-devel] Re: [Rt-commit] r6484 - rt/branches/3.6-EXPERIMENTAL-LONDRES/html/Elements

[Ruslan Zakirov]

In most cases we shouldn't use $m->abort as this call stop things at
point where you're now, so you loose next components (footer and so
on), but when you want replace on component with another like in this
situation then I would suggest to use "return $m->comp..." instead of
"$m->comp(...); return;".

On 11/21/06, clkao at bestpractical.com <clkao at bestpractical.com> wrote:
> Author: clkao
> Date: Tue Nov 21 15:20:33 2006
> New Revision: 6484
>
> Modified:
>    rt/branches/3.6-EXPERIMENTAL-LONDRES/html/Elements/ShowSearch
>
> Log:
> No we don't really want to abort.
>
> Modified: rt/branches/3.6-EXPERIMENTAL-LONDRES/html/Elements/ShowSearch
> ==============================================================================
> --- rt/branches/3.6-EXPERIMENTAL-LONDRES/html/Elements/ShowSearch       (original)
> +++ rt/branches/3.6-EXPERIMENTAL-LONDRES/html/Elements/ShowSearch       Tue Nov 21 15:20:33 2006
> @@ -68,7 +68,7 @@
>      if ( $SearchArg->{SearchType} ne 'Ticket' ) {
>          # XXX: dispatch to different handler here
>          $m->comp( '/Search/Elements/Chart', %$SearchArg );
> -        $m->abort;
> +        return;
>      }
>      $customize = $RT::WebPath.'/Search/Build.html?'.
>         $m->comp('/Elements/QueryString',
> _______________________________________________
> Rt-commit mailing list
> Rt-commit at lists.bestpractical.com
> http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-commit
>


-- 
Best regards, Ruslan.