[Rt-devel] Suggestion: Add class and id attributes to form elements

[Jesse Vincent]

On Mon, Oct 30, 2006 at 09:28:03PM +0200, Alexandr Ciornii wrote:
> Hello!
> 
> 2006/10/27, Jesse Vincent <jesse at bestpractical.com>:
> >It's something we'd be thrilled to do. We'd be even more thrilled if 
> >someone started sending patches..
> 
> Patch for html/Elements/MessageBox. Adds id="messagebox".
> IMHO, class="messagebox" should remain for compatibility reasons.

My one concern is that it's quite possible to use "MessageBox" twice on
one page. Why not make the id == the name here?

-j

> 
> -- 
> Alexandr Ciornii, http://chorny.net

> --- MessageBox.dist	Tue Jun 20 01:44:04 2006
> +++ MessageBox	Fri Oct 27 23:23:55 2006
> @@ -43,7 +43,7 @@
>  %# those contributions and any derivatives thereof.
>  %# 
>  %# END BPS TAGGED BLOCK }}}
> -<textarea class="messagebox" cols="<%$Width%>" rows="<%$Height%>" wrap="<%$Wrap%>" name="<%$Name%>"><& /Elements/Callback, %ARGS &><% $Default %><%$message%><%$IncludeSignature ? $signature : ''%></textarea>
> +<textarea class="messagebox" id="messagebox" cols="<%$Width%>" rows="<%$Height%>" wrap="<%$Wrap%>" name="<%$Name%>"><& /Elements/Callback, %ARGS &><% $Default %><%$message%><%$IncludeSignature ? $signature : ''%></textarea>
>  <%INIT>
>  
>  my $message = '';

> _______________________________________________
> List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel

--