[Rt-devel] Re: [Rt-commit] r7217 - rt/branches/3.7-EXPERIMENTAL-TUNIS/lib

[Jesse Vincent]

On Mon, Mar 12, 2007 at 11:50:32AM -0400, ruz at bestpractical.com wrote:
> Author: ruz
> Date: Mon Mar 12 11:50:31 2007
> New Revision: 7217
> 
> Modified:
>    rt/branches/3.7-EXPERIMENTAL-TUNIS/lib/RT.pm.in
> 
> Log:
> * rename RT::Handle sub into RT::DatabaseHandle as the first one conflicts with
>   RT::Handle package

It's conflicted for a long time. And this _will_ break existing code.
I'm ok with changing the preferred name, but please leave a
compatibility alias in place. (Not a deprecation warning. A
compatibility alias.)


> Modified: rt/branches/3.7-EXPERIMENTAL-TUNIS/lib/RT.pm.in
> ==============================================================================
> --- rt/branches/3.7-EXPERIMENTAL-TUNIS/lib/RT.pm.in	(original)
> +++ rt/branches/3.7-EXPERIMENTAL-TUNIS/lib/RT.pm.in	Mon Mar 12 11:50:31 2007
> @@ -132,7 +132,7 @@
>  
>  sub Init {
>      ConnectToDatabase();
> -    InitSystemObjects;
> +    InitSystemObjects();
>      InitClasses();
>      InitLogging(); 
>  }
> @@ -385,7 +385,7 @@
>  
>  sub Config { return $Config }
>  
> -=head2 Handle
> +=head2 DatabaseHandle
>  
>  Returns the current L<database handle object RT::Handle>.
>  
> @@ -393,7 +393,7 @@
>  
>  =cut
>  
> -sub Handle { return $Handle }
> +sub DatabaseHandle { return $Handle }
>  
>  =head2 Logger
>  
> _______________________________________________
> Rt-commit mailing list
> Rt-commit at lists.bestpractical.com
> http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-commit
> 

--