[Rt-devel] [patch] 3.8.1 Simple Search text clarification & consistent HTML

[Jesse Vincent]

Thanks!


It makes the most sense to apply this to the release after RT 3.8, as  
it will break all of RT's translations, which makes it somewhat  
undesirable to apply in the middle of a stable series.

It's useful to send patches as attachments, so they can be saved to  
disk for application cleanly.  Similarly, one should generally diff  
with the "old" version first in your commandline like so:

	diff -ur old new

Doing otherwise has the diff reversed and will leave the developers  
looking at the patch trying to figure out why you removed the nice  
semantic <strong> and <em> markup for ugly <b> and <i> markup ;)

It's also good style to include the text of your description in the  
body of the message, but that matters less ;)

If you can regen the patch easily, shoot it over to rt-bugs at bestpractical.com 
  so we don't lose track of it for the future.

Again, thanks for the patch!

-jesse


On Sep 14, 2008, at 3:40 PM, Jerrad Pierce wrote:

> --- share/html/Search/Simple.html       2008-09-14  
> 15:30:27.000000000 -0400
> +++ share/html/Search/Simple.html~      2008-08-30  
> 19:22:14.000000000 -0400
> @@ -58,7 +58,7 @@
>
>  <p><&|/l&>Search for tickets. Enter <strong>id</strong> numbers,  
> <strong>queues</strong> by name, Owners by <strong>username</strong>  
> and Requestors by <strong>email address</strong>.</&></p>
>
> -<p><&|/l&>Searching the full text of every ticket can take a long  
> time, but if you need to do it, you can search for any word in full  
> ticket history by typing <strong>fulltext:<em>keyword</em></ 
> strong>.</&></p>
> +<p><&|/l&>Searching the full text of every ticket can take a long  
> time, but if you need to do it, you can search for any word in full  
> ticket history for any word by typing <b>fulltext:<i>word</i></b>.</ 
> &></p>
>  <p><&|/l&>RT will look for anything else you enter in ticket  
> subjects.</&></p>
>
>  <br />
>
>
> -- 
> Cambridge Energy Alliance: Save money & the planet
> _______________________________________________
> List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel