[Rt-devel] Ingres port of RT

[Jesse Vincent]

On Wed, Dec 16, 2009 at 12:40:05PM -0500, Keith Bolam wrote:
> Hi Jesse,
> Thanks for the comments!
> I'm just starting the port of the test suite code - there are some
> aspects of this that need to be modified to accept the Ingres database
> changes.

Without seeing what you've got now and what those changes are, I can't
say for sure, but in general if the test suite needs to be modified for
a specific database engine, that's a red flag.


> I will be looking at getting the changes into an ordered fashion so that
> the changes are readable and explainable. As this is the first time of
> using git I'm walking slowly with it and trying to RTFM at the same time
> as developing the Perl changes that are required.

Understood. git is...fairly picky about who its friends are.  One option
here might actually just be to register a github.com account and publish
your repository there.  (github is quite user-friendly)

> Re the DBSD::Ingres driver I'll contact the author and see how the
> ground lies there.  An option would be to share the ownership of the
> Perl driver with the author (htoug at cpan.org) so that they have an Ingres
> connection.

It's probably not right to offer to share ownership of a CPAN module
that doesn't look like abandonware as your first contact. Many
maintainers are perfectly happy to take contributions but wouldn't want
to "give up" the control they get as the project lead.  But everyone is
different. Drop the author a line and see what they say.

> I will look at how to create a diff / path file for git (guidance
> accepted !)

Assuming you started from a git clone of RT, the following MAY do what
you want. But for something of this scale, just publishing to github is
great.

git diff remotes/origin/3.8-trunk HEAD

Best,
Jesse

> Keith 
> 
> 
> -----Original Message-----
> From: Jesse Vincent [mailto:jesse at bestpractical.com] 
> Sent: 16 December 2009 17:29
> To: Keith Bolam
> Cc: rt-devel at lists.bestpractical.com; Emma K. McGrattan
> Subject: Re: Ingres port of RT
> 
> Hi Keith,
> 
> > I have completed a port of RT to run on the Ingres database - all 
> > appears to be going well and I would like to submit an integration 
> > plan to the list for approval and submission into the main code line 
> > to make Ingres a supported database.
> 
> That's great to hear. The right first step here is probably to send a
> patch to rt-devel for comments and suggestions.
> 
> > Wit the changes made to various files including the creation of a new 
> > SerachBuilder/Handle/Ingres.pm driver I would now like to make this 
> > available to the Perl and RT community.  There are also changes to be 
> > made to the DBD::Ingres driver for Perl with the addition of the
> > last_insert_id() function.
> 
> Fantastic.  For DBD::Ingres, you'll probably want to do "whatever the
> maintainer recommends" in the docs, which may be opening an rt.cpan.org
> ticket or contacting them directly.
> 
> > As I am new to both RT and Perl and Open Source committing I would 
> > like to engage with a mentor to get all of these changes completed.
> 
> Welcome! That mentor is probably me. (Convenient as I'm also the guy who
> gets to make the ultimate go/no-go decision ;)
> 
> As the person making the decision about whether or not to take the
> patch:
> 
> 1) Have you run RT's regression test suite with Ingres? Did all tests
> pass?
> 
> 2) I'd love to see the current state of the patches. (Just send them to
> the list.) I don't suppose you have a version control system you can
> expose to the public so we can see your development process and examine
> each change in isolation? While that's often considered "ideal" for
> large changes, it's certainly not a showstopper.
> 
> Best,
> Jesse
> 

--