[Rt-devel] Patch for RT-Extension-ResetPassword

[Jason Fenner]

On Tue, Jun 23, 2009 at 5:55 PM, Kevin Falcone <falcone at bestpractical.com>wrote:

> On Jun 23, 2009, at 11:24 AM, Jason Fenner wrote:
>
> > Please find attached a patch for RT-Extension-ResetPassword.
> > This patch corrects two spots that do not build links correctly.
> > The links now obey $RT::WebURL
>
> Two issues, you're interpolating RT::WebURL inside a single
> quoted string which won't work, and you really want $RT::WebPath
> because these are RT internal links.  Take a look at the patch
> I applied to:
> html/Callbacks/RT-Extension-ResetPassword/Elements/Login
>
> -kevin
> _______________________________________________
> List info:
> http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel
>

Thanks for pointing that out.

I have created a new patch with using $RT::WebPath and not interpolated
within a quoted string.


-- 
Jason 'axelilly' Fenner
GTalk: axelilly at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.bestpractical.com/pipermail/rt-devel/attachments/20090624/c2cef1a9/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: RT-Extension-ResetPassword.urlfix.2.diff
Type: application/octet-stream
Size: 1535 bytes
Desc: not available
Url : http://lists.bestpractical.com/pipermail/rt-devel/attachments/20090624/c2cef1a9/attachment.obj