[Rt-devel] [Rt-commit] r18632 - rt/3.8/trunk/lib/RT/Action

[Jesse Vincent]

On Tue  3.Mar'09 at 15:53:37 +0100, Emmanuel Lacour wrote:
> On Tue, Mar 03, 2009 at 09:41:38AM -0500, Jesse Vincent wrote:
> > 
> > On Tue  3.Mar'09 at 15:37:05 +0100, Emmanuel Lacour wrote:
> > > > I _know_ I've used values like "on", "true" and "y" in the patch.
> > > > 
> > > > how about instead matching on no|0|off?
> > > > 
> > > 
> > > well, that's not common to do such thinks, think that maybe in future we
> > > can find other values for this header to do other message attachement
> > > related thinks.
> > > but if you think that maching for y/yes/on/true can break existing
> > > configs, I can do that.
> > 
> > Basically, when adding a new feature to deal with a previously uncovered
> > case, the conservative thing to do is to explicitly and carefully match
> >  on your new case, rather than make guesses about how people might be
> > using the existing feature in the wild.  By matching tightly on '^yes$',
> > you've effectively changed the default. And changing defaults out from
> > under people is bad.
> > 
> 
> Ok I commited a fix in this way.

Thanks! 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
Url : http://lists.bestpractical.com/pipermail/rt-devel/attachments/20090303/87c9ab76/attachment.pgp