[Rt-devel] [Rt-commit] r19576 - rt/3.8/trunk/lib/RT/Interface

[Ruslan Zakirov]

Shouldn't we encode according to outgoing encoding we define in the
config? And do it using the method we use for other outgoing emails.
This should be covered with tests for latin1 chars and else chacters:
russian, chinese or something else outside latin1.

On Thu, May 7, 2009 at 12:08 PM,  <elacour at bestpractical.com> wrote:
> Author: elacour
> Date: Thu May  7 04:08:18 2009
> New Revision: 19576
>
> Modified:
>   rt/3.8/trunk/lib/RT/Interface/Email.pm
>
> Log:
> Properly MIME encode (RFC 2047) headers of forwarded messages, so for example
> non ascii subject are properly displayed in MUA.
>
> Modified: rt/3.8/trunk/lib/RT/Interface/Email.pm
> ==============================================================================
> --- rt/3.8/trunk/lib/RT/Interface/Email.pm      (original)
> +++ rt/3.8/trunk/lib/RT/Interface/Email.pm      Thu May  7 04:08:18 2009
> @@ -622,7 +622,7 @@
>         );
>     }
>
> -    $mail->head->set( $_ => $args{ $_ } )
> +    $mail->head->set( $_ => Encode::encode('MIME-Header', $args{ $_ }) )
>         foreach grep defined $args{$_}, qw(To Cc Bcc);
>
>     $mail->attach(
> @@ -643,8 +643,8 @@
>         $from = $obj->QueueObj->CorrespondAddress
>             || RT->Config->Get('CorrespondAddress');
>     }
> -    $mail->head->set( Subject => "Fwd: $subject" );
> -    $mail->head->set( From    => $from );
> +    $mail->head->set( Subject => Encode::encode('MIME-Header', "Fwd: $subject") );
> +    $mail->head->set( From    => Encode::encode('MIME-Header', $from) );
>
>     my $status = RT->Config->Get('ForwardFromUser')
>         # never sign if we forward from User
> _______________________________________________
> Rt-commit mailing list
> Rt-commit at lists.bestpractical.com
> http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-commit
>



-- 
Best regards, Ruslan.