[Rt-devel] [Rt-commit] r19576 - rt/3.8/trunk/lib/RT/Interface

[Kevin Falcone]

On May 11, 2009, at 2:19 PM, Ruslan Zakirov wrote:

> Ok. I should look into it and really think it's time to release 3.8.3.
> As this is not a regression since 3.8.0 where it's broken in the same
> way as in 3.8.2, so I don't think this should block 3.8.3.

I created a branch forward-with-transaction for some post-3.8.3
work so this may want to happen on that branch or on a separate
feature branch.  I'm probably going to take these commits and
move them onto a branch and out of the 3.8.3-releng branch
and trunk later today if I can.

-kevin

>
>
> On Sat, May 9, 2009 at 12:25 PM, Emmanuel Lacour
> <elacour at easter-eggs.com> wrote:
>> On Sat, May 09, 2009 at 12:42:15AM +0400, Ruslan Zakirov wrote:
>>> Shouldn't we encode according to outgoing encoding we define in the
>>> config? And do it using the method we use for other outgoing emails.
>>> This should be covered with tests for latin1 chars and else  
>>> chacters:
>>> russian, chinese or something else outside latin1.
>>>
>>
>> In this patch, I'm just fixing headers of the mail forward (not the
>> forwarded email). And as it is made of forwarded email subject that  
>> may
>> contain non ascii chars and as it's possible to have To/Cc/Bcc that
>> contains a name with non-ascii chars, I encoded those headers with  
>> rfc
>> 2047.
>>
>> But maybe it's possible to use same code as other outgoing emails,  
>> but
>> that needs whole refactoring of forward method.
>>
>>
>
>
>
> -- 
> Best regards, Ruslan.
> _______________________________________________
> List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel
>