[Rt-devel] [rt-users] mobile interface reply link.

[Jason A. Smith]

Hi Jesse,

I tried version 1.01, but it didn't work for me ($Action => 'reply').  I 
think it is because the template is looking for Action to be exactly 
'Respond', see line 100 of html/m/ticket/reply:

99  my ($CommentDefault, $ResponseDefault);
100 if ($Action ne 'Respond') {
101     $CommentDefault = qq[ selected="selected"];
102     $ResponseDefault = "";
103 } else {
104     $CommentDefault = "";
105     $ResponseDefault = qq[ selected="selected"];
106 }

Thanks,
~Jason


On 12/08/2010 11:36 AM, Jesse Vincent wrote:
> Thanks, applied, released as 1.01
>
>
> On Tue  7.Dec'10 at 16:14:31 -0500, Jason A. Smith wrote:
>> I thought it would be better to send this to the devel list instead.
>>
>> The attached patch makes the default action Respond instead of
>> Comment, which now agrees with the link text that says Reply.  With
>> Action defaulting to undef, the template was assuming Comment.
>>
>> ~Jason
>>
>>
>> On 12/02/2010 11:28 AM, Jason A. Smith wrote:
>>> On the ticket display of the mobile interface, at the top, there are
>>> three links for Basics, History&  Reply. I used the reply link without
>>> looking closely and it actually made a comment instead of a reply. Can
>>> this default action be changed easily? Also, since it does not default
>>> to a reply, shouldn't the link text be changed to Comment instead?
>>
>
>> diff -ur RT-Extension-MobileUI-1.00-dist/html/m/ticket/reply RT-Extension-MobileUI-1.00/html/m/ticket/reply
>> --- RT-Extension-MobileUI-1.00-dist/html/m/ticket/reply	2010-08-06 11:08:52.000000000 -0400
>> +++ RT-Extension-MobileUI-1.00/html/m/ticket/reply	2010-12-06 17:06:06.000000000 -0500
>> @@ -166,6 +166,6 @@
>>
>>   <%ARGS>
>>   $id =>  undef
>> -$Action =>  undef
>> +$Action =>  'Respond'
>>   $DefaultStatus =>  undef
>>   </%ARGS>
>>
>
>
>
>
>> _______________________________________________
>> List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel
>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4068 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.bestpractical.com/pipermail/rt-devel/attachments/20101209/8b7e55f0/attachment.bin>