[Rt-devel] [patch] RT::Interface::Web _Overlay/_Vendor/_Local not being included

[Ruslan Zakirov]

Hello,

This is still doesn't return old behaviour. Which was with side effects.

Old code was loading .../Web_Local.pm, but code was compiled in
HTML::Mason::Commands space unless explicit package is defined in
_Local.pm file.

On Wed, Apr 20, 2011 at 9:44 PM, Ivan Kohler <ivan-rt-devel at 420.am> wrote:
> RT::Interface::Web_Overlay, Web_Vendor and Web_Local are not being
> called.
>
> This is a regression from RT 3.8.9->3.8.10 and also affects 4.0.0rc8
>
> RT::Interface::Web is in package HTML::Mason::Commands when it calls
> RT::Base->_ImportOverlays, so it looks for the wrong files.
>
> I figured reworking _ImportOverlays to use the calling filename instead
> of calling package is not desirable (but I'd be happy to give that a
> shot if you prefer), so this patch fixes things:
>
>
> diff -u lib/RT/Interface/Web.pm.DIST lib/RT/Interface/Web.pm
> --- lib/RT/Interface/Web.pm.DIST        2011-04-20 10:33:53.000000000 -0700
> +++ lib/RT/Interface/Web.pm     2011-04-20 10:34:04.000000000 -0700
> @@ -2756,6 +2756,7 @@
>     return $scrubber;
>  }
>
> +package RT::Interface::Web;
>  RT::Base->_ImportOverlays();
>
>  1;



-- 
Best regards, Ruslan.