[rt-devel] ckeditor.js always loaded

Alex Vandiver alexmv at bestpractical.com
Tue Apr 1 12:37:13 EDT 2014

On Mon, 2014-03-31 at 14:21 +0200, Christian Loos wrote:
> this addresses the following commit:
> https://github.com/bestpractical/rt/commit/c1c91d2a1d65153a555a52698660f9db85670149
> From the commit message it sounds really odd to me to always load the
> 130k ckeditor.js to have ability to disable ckeditor on some textareas
> in RTIR.
> The ckeditor is only used on very few pages within RT. Maybe there is a
> better way to load the ckeditor.js only on the pages where it is needed
> and only if $MessageBoxRichText is set to true.

This pushes the ckeditor JS to being loaded on the first page load
(generally the login page), where any delay is less noticeable than when
a user is gung-ho to reply, and must wait for the JS to load.  It also
allows us to combine it with the existing JS, which works around the
serial requesting which browsers do for resources from the same server.

It does incur a small penalty on sites which have
Set($MessageBoxRichText, 0) in their configurations, and for users that
have disabled it in their preferences.  However, caching amortizes this
cost sufficiently that it far outweighs the code complexity that would
come with a solution that attempts to "smartly" load the ckeditor JS (or
not) on a per-page basis.

 - Alex

More information about the rt-devel mailing list