[rt-devel] Patch to add aria labels to SelectionBox arrow buttons

Keith Creasy kcreasy at aph.org
Thu Jul 3 10:42:42 EDT 2014

Thanks Kevin.

I'm not sure how the executable bits got in there. I'll watch for that in the future.

I just noticed some other unlabeled buttons, this time in the widget where you edit columns included in a search. I'll fix that for us and can send a patch for that as well if you like.


-----Original Message-----
From: rt-devel [mailto:rt-devel-bounces at lists.bestpractical.com] On Behalf Of Kevin Falcone
Sent: Thursday, July 03, 2014 10:09 AM
To: rt-devel at lists.bestpractical.com
Subject: Re: [rt-devel] Patch to add aria labels to SelectionBox arrow buttons

On Mon, Jun 30, 2014 at 09:55:32PM +0000, Keith Creasy wrote:
> I tested with two screen readers but here is more information. It is widely supported.
> For general information about WAI ARIA see 
> http://www.w3.org/WAI/intro/aria
> Current support is at least mentioned at 
> https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA
> The bottom line is that using ARIA attributes breaks nothing, if 
> screen readers and browsers don't know about it then it is ignored. If 
> you or someone else wants to change the value of the button to have a 
> real label you can and, again, nothing is broken. There just isn't a 
> good reason not to use it here as a way to support accessibility 
> without having to change your user interface.

Thanks for the references.
I've pushed a branch with your patch (although I did fix the fact that you added executable bits somewhere along the line).  I'll merge it later today and it should show up in 4.2.6 when we release it.


More information about the rt-devel mailing list