[rt-devel] questions regarding limit attachment size

[Christian Loos]

Hi,

I have some questions regarding the functions to limit the attachment
size ($MaxAttachmentSize and $DropLongAttachments set):

1. Is it really necessary to log the first 60 characters of a dropped
attachment [1]?

2. As RT creates a attachment drop transaction (since RT 4.2.7), is it
still necessary to create a text attachment with the Content "Large
attachment dropped" for dropped attachments [2]?
The informations the text attachments make available are also available
by the "attachment drop" transaction (date, user, filename, filesize)
and thus are redundant (just to note that the transaction also shows the
$MaxAttachmentSize).

3. Wouldn't it be better to check an uploaded attachment on
Ticket/Create.html and Ticket/Update.html against the $MaxAttachmentSize
and give the user an error message (which gives the user a chance to
attach a smaller attachment) and abort the ticket create/update instead
of creating or updating the ticket with a "attachment drop" transaction

4. Maybe Ticket/Elements/AddAttachments should show a hint on the
$MaxAttachmentSize (if set) to prevent users from try to upload
attachments which are greater than $MaxAttachmentSize.


Chris

[1] https://github.com/bestpractical/rt/blob/stable/lib/RT/Record.pm#L832
[2] https://github.com/bestpractical/rt/blob/stable/lib/RT/Record.pm#L841