[rt-devel] Attempting to make Subject: tag matching a little more permissive, diff enclosed

Alexis Rosen alexis at panix.com
Wed Sep 28 16:36:07 EDT 2016


On Sep 28, 2016, at 4:02 PM, Jim Brandt <jbrandt at bestpractical.com> wrote:
> Your approach could work (you don't mention which version of RT, recent versions changed incoming email handling).

Thanks for the response. The version is 4.2.12.

> Another approach to limit the scope of your change would be to search for incoming mail only from that email address (or domain, if there are many) and update the subject to put the space back in. The main advantages here are: 1) you limit the scope of the change to just email from that address and 2) you're making it look like RT expects, which is less likely to miss some other location that assumes subject will be in the specified format.

You think some other part of the code duplicates the function of ParseTicketId()?

I'm not worried about mail from other addresses. If their Subject: is matched by that regex, I want it handled the same way.

> You could do this with some tool before the email gets into RT or by adding an email processing step somewhere before the code below.
> 
> Either way, if you make changes, do it in an override library in local, not in the main code. That way it's simple to revert if it doesn't behave as you expect.

Can you point me to a doc describing "override libraries"? This is my first look at RT source and I'm not familiar with how it's organized. Google is less than helpful here, so far.

I take it from this that you're not interested in merging the patch?

Thanks,
/a


More information about the rt-devel mailing list