[rt-users] internal bookmarks are bogus in RT2

[Sheeri Kritzer]

(this is for RT2, but is really a minor change, can someone running RT3 check and see if it's an RT3 bug too?)

One of my users pointed out:

according to the HTML 4.01 spec, name and id attributes 'must begin with
a letter ([A-Za-z]) and may be followed by any number of letters, digits
([0-9]), hyphens ("-"), underscores ("_"), colons (":"), and periods (".")'

see:
http://www.w3.org/TR/html401/types.html#type-name

along these lines, RT creates wicked bogus name values for internal
bookmark values, e.g. <a NAME="#24509"></a> 

[1] the hash (#) is illegal.
[2] it can't start w/ a number

to make it a valid attribute, change Ticket/Elements/ShowTransaction

[old line]
<TD bgcolor="<%$bgcolor%>"><A NAME="#<%$Transaction->Id%>"></A>&nbsp </TD>

[new line]
<TD bgcolor="<%$bgcolor%>"> <a name="c<%$Transaction->Id%></A>&nbsp </TD>

is this going to break anything?

Also, he actually wanted to refer to it, so the line in my local file actually is:

<a name="c<%$Transaction->Id%>" href="#c<%$Transaction->Id%>">#</a>

that just makes a link labeled "#" next to every comment.  He wants to be able to link to specific comments, instead of just a ticket, for that.  A minor improvement, but some people like that.

-Sheeri Kritzer
Systems Administrator
University Systems Group
Tufts University
617-627-3925
sheeri.kritzer at tufts.edu