[rt-users] checkboxes without value don't work

[Koos van den Hout]

One of our RT users complained that he could not delete ticket watchers,
and I found the reason: he uses a recent browser and when an input checkbox
entity has no value, it won't get passed (see
http://www.w3.org/TR/REC-html40/interact/forms.html for the 'rules').

So, I created a local/html/Ticket/Elements/EditWatchers with that
correction, and now stuff works. Diff below.

Please fix this upstream, in all cases of input type="CHECKBOX"

*** share/html/Ticket/Elements/EditWatchers     Thu Jul 29 02:08:11 2004
--- local/html/Ticket/Elements/EditWatchers     Tue Apr 12 11:55:06 2005
***************
*** 52,58 ****
  
  %while (my $watcher=$Members->Next) {
  <li>
! <INPUT TYPE=CHECKBOX NAME="Ticket-DeleteWatcher-Type-<%$Watchers->Type%>-Principal-<%$watcher->MemberId%>" UNCHECKED>
  %if ($watcher->MemberObj->IsUser) { 
  <a href="<%$RT::WebPath%>/Admin/Users/Modify.html?id=<%$watcher->MemberObj->Object->id%>">
  <%$watcher->MemberObj->Object->Name%></a>
--- 52,58 ----
  
  %while (my $watcher=$Members->Next) {
  <li>
! <INPUT TYPE=CHECKBOX NAME="Ticket-DeleteWatcher-Type-<%$Watchers->Type%>-Principal-<%$watcher->MemberId%>" VALUE="1" UNCHECKED>
  %if ($watcher->MemberObj->IsUser) { 
  <a href="<%$RT::WebPath%>/Admin/Users/Modify.html?id=<%$watcher->MemberObj->Object->id%>">
  <%$watcher->MemberObj->Object->Name%></a>


-- 
Koos van den Hout,           PGP keyid RSA/1024 0xCA845CB5 via keyservers
koos at kzdoos.xs4all.nl        or DSS/1024 0xF0D7C263                        -?)
Fax +31-30-2817051              Visit the site about books with reviews    /\\
http://idefix.net/~koos/                http://www.virtualbookcase.com/   _\_V
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 248 bytes
Desc: not available
URL: <http://lists.bestpractical.com/pipermail/rt-users/attachments/20050412/53db4d62/attachment.sig>