[rt-users] Anybody using SelectRequestor?

[Kelly F. Hickel]

  _____  

From: Ruslan Zakirov [mailto:ruslan.zakirov at gmail.com] 
Sent: Wednesday, August 31, 2005 9:30 AM
To: Kelly F. Hickel
Cc: Ben Robson; Jörg Ungermann; rt-users at lists.bestpractical.com
Subject: Re: [rt-users] Anybody using SelectRequestor?

 

Code looks a little bi confusing

On 8/31/05, Kelly F. Hickel <kfh at mqsoftware.com> wrote:

If there's no org value for a user, it's not put into the list.  That's easy to change, just add an else clause to the if statement below, may put them all in an org called "NoOrg" or something....

 

    if((!defined ($org)) || ($org eq "")) {

This condition is equivalent of
  unless( $org ) {
which is much simpler to understand

[Kelly F. Hickel] Hmm, well, maybe.  I've been writing C code for over 20 years, and have been told that my perl code looks like C.  I take that as a compliment.  ;>  I would argue that the way that I wrote it is clearer to someone that doesn't live and breathe perl, which seems to apply to a lot of people that use RT.

	 

	      my $i = index($User->Name, "@");
	      # Note that if index returned -1, we'll start at zero, just using the entire email addr as the org
	 
	      $org = substr $User->Name, $i+1;
	    }

	 

	So: 

	Else {

	$org = "NoOrg";

	}


I think this is wrong suggestion, will trigger situation when org is defined.

[Kelly F. Hickel] It's the wrong suggestion because the code already handles this case, but I forgot about it.  Users with no org will be entered in the dropdown list with their email domain name as the org.  So there's no need to change the code anyway, as it already handles the case.





	-- 

	Kelly F. Hickel
	Senior Software Architect
	MQSoftware, Inc
	952.345.8677
	kfh at mqsoftware.com

	
  _____  


	From: rt-users-bounces at lists.bestpractical.com [mailto:rt-users-bounces at lists.bestpractical.com] On Behalf Of Ben Robson
	Sent: Wednesday, August 31, 2005 8:04 AM
	To: Jörg Ungermann; rt-users at lists.bestpractical.com
	Subject: RE: [rt-users] Anybody using SelectRequestor?

	 

	Jorg,
	
	Double check your permissions.  Initially I found that only my priv' users were showing up, but then later when I re-did the permissions for the unpriv' users, they too started showing up.
	
	I also suspect, but have not tested, you need to make sure that all users belong to a "Company Name" in their personal settings.  I suspect without a "Company Name" the script would not find them, or would not know where to group them.
	
	BenR
	
	
	-----Original Message-----
	From: rt-users-bounces at lists.bestpractical.com on behalf of Jörg Ungermann
	Sent: Wed 8/31/2005 6:52 PM
	To: rt-users at lists.bestpractical.com
	Subject: [rt-users] Anybody using SelectRequestor?
	
	
	I just found the RT contribution SelectRequestor.
	
	It makes it possible to select users from lists when creating new tickets (instead of typing tem in)
	
	It seems to work but i cannpot get more than 1 user (and root in addition) listed.
	
	Anybody having this up and running?
	Is there a solution to get all users listed?
	
	Thanks
	
	Joerg
	______________________________________________________________
	Verschicken Sie romantische, coole und witzige Bilder per SMS!
	Jetzt bei WEB.DE FreeMail: http://f.web.de/?mc=021193
	
	_______________________________________________
	http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users
	
	Be sure to check out the RT Wiki at http://wiki.bestpractical.com
	
	Buy your copy of our new book, RT Essentials, today!
	
	Download a free sample chapter from http://rtbook.bestpractical.com

	
	_______________________________________________
	http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users 
	
	Be sure to check out the RT Wiki at http://wiki.bestpractical.com
	
	Buy your copy of our new book, RT Essentials, today! 
	
	Download a free sample chapter from http://rtbook.bestpractical.com




-- 
Best regards, Ruslan. 

 

 

-- 

Kelly F. Hickel
Senior Software Architect
MQSoftware, Inc
952.345.8677
kfh at mqsoftware.com

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bestpractical.com/pipermail/rt-users/attachments/20050831/c516b58b/attachment.htm>