[rt-users] RT::CustomField -> Queue deprecated at(RT::Tickets:/opt/rt3/local/lib/RT/Tickets_Overlay.pm:2245)

[Peer Michael]

Hello,

One year ago, I wrote this to the Mailinglist. Now I have upgraded my RT
to 3.8.0 and now the function 
$tickets->LimitCustomField(CUSTOMFIELD => 'xxxx', OPERATOR => 'LIKE',
VALUE => 'true');
doesn't work any more. 
The reason is, that the function Queue in CustomField_Overlay.pm, marked
as deprecated in rt-3.4.5, is now eliminated, but is still called in
function LimitCustomField (Tickets_Overlay.pm, line 2466).
I think, that this part can be removed, because it does not do anything.
This diff removes this part:

--- /opt/rt3/lib/RT/Tickets_Overlay.pm      2008-07-14
16:30:19.000000000 +0200
+++ /opt/rt3/local/lib/RT/Tickets_Overlay.pm        2008-07-22
10:54:54.000000000 +0200
@@ -2462,12 +2464,7 @@
             $CF->Name, $args{OPERATOR}, $args{VALUE} );
     }

-    my $q = "";
-    if ( $CF->Queue ) {
-        my $qo = new RT::Queue( $self->CurrentUser );
-        $qo->Load( $CF->Queue );
-        $q = $qo->Name;
-    }

     my @rest;
     @rest = ( ENTRYAGGREGATOR => 'AND' )
@@ -2477,9 +2474,7 @@
         VALUE => $args{VALUE},
         FIELD => "CF."
             . (
-              $q
-            ? $q . ".{" . $CF->Name . "}"
-            : $CF->Name
+            $CF->Name
             ),
         OPERATOR    => $args{OPERATOR},
         CUSTOMFIELD => 1,


What's your opinion about eliminating the above snippet?

Michael Peer


 

-----Original Message-----
From: Jesse Vincent [mailto:jesse at bestpractical.com] 
Sent: Wednesday, 14 February, 2007 13:55
To: Peer Michael
Cc: rt-users at lists.bestpractical.com
Subject: Re: [rt-users] RT::CustomField -> Queue deprecated
at(RT::Tickets:/opt/rt3/local/lib/RT/Tickets_Overlay.pm:2245)




On Wed, Feb 14, 2007 at 10:41:11AM +0100, Peer Michael wrote:
> I never get a response to this problem. Any idea?

Ruslan did reply. It's fixed in newer releases. But don't worry about
the issue. It's harmless.

> 
> Michael Peer
> 
> -----Original Message-----
> From: rt-users-bounces at lists.bestpractical.com
> [mailto:rt-users-bounces at lists.bestpractical.com] On Behalf Of Peer 
> Michael
> Sent: Thursday, 01 February, 2007 08:52
> To: Ruslan Zakirov
> Cc: rt-users at lists.bestpractical.com
> Subject: RE: [rt-users] RT::CustomField -> Queue deprecated
> at(RT::Tickets:/opt/rt3/local/lib/RT/Tickets_Overlay.pm:2245)
> 
> I'm using rt-3.4.5.
>  
> 
> -----Original Message-----
> From: Ruslan Zakirov [mailto:ruslan.zakirov at gmail.com]
> Sent: Wednesday, 31 January, 2007 17:52
> To: Peer Michael
> Cc: rt-users at lists.bestpractical.com
> Subject: Re: [rt-users] RT::CustomField -> Queue deprecated at
> (RT::Tickets:/opt/rt3/local/lib/RT/Tickets_Overlay.pm:2245)
> 
> On 1/31/07, Peer Michael <Michael.Peer at eurac.edu> wrote:
> >
> >
> > Greeting
> >
> > When i use the function
> > "$tickets->LimitCustomField(CUSTOMFIELD => 'xxxx', OPERATOR => 
> > 'LIKE',
> 
> > VALUE => 'true');" i find this message in the log:
> > [Wed Jan 31 15:47:34 2007] [debug]: RT::CustomField -> Queue 
> > deprecated at
> > (RT::Tickets:/opt/rt3/local/lib/RT/Tickets_Overlay.pm:2245)
> > (/opt/rt3/lib/RT/CustomField_Overlay.pm:741)
> >
> > How can i avoid this message?
> Update to newer version of the RT? Or at least say us what version 
> you're using.
> 
> >
> > Thanks
> >
> 
> --
> Best regards, Ruslan.
> _______________________________________________
> http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users
> 
> Community help: http://wiki.bestpractical.com Commercial support: 
> sales at bestpractical.com
> 
> 
> Discover RT's hidden secrets with RT Essentials from O'Reilly Media. 
> Buy a copy at http://rtbook.bestpractical.com 
> _______________________________________________
> http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users
> 
> Community help: http://wiki.bestpractical.com Commercial support: 
> sales at bestpractical.com
> 
> 
> Discover RT's hidden secrets with RT Essentials from O'Reilly Media.
> Buy a copy at http://rtbook.bestpractical.com
> 

--