[rt-users] FW: Long Lines on ticket display page

Jesse Vincent jesse at bestpractical.com
Wed Nov 25 12:17:34 EST 2009




On Wed, Nov 25, 2009 at 09:10:30AM -0800, Potla, Ashish Bassaliel wrote:
> Sorry about that . It is 3.8.2 (mod_perl2) on a sun solaris machine with an Oracle Db.
>

We've definitely made wrapping improvements in the past couple point
releases. And one since that last release:

commit 4eb846f4b7da66940f6bc479a0367d226969e99d
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Fri Oct 30 14:54:21 2009 -0400

    RT was accidentally injecting too many newlines when rendering plaintext messages without <pre>.
    
    This commit fixes the regex.

diff --git a/share/html/Ticket/Elements/ShowMessageStanza b/share/html/Ticket/Elements/ShowMessageStanza
index e9b57bb..0d4fe61 100755
--- a/share/html/Ticket/Elements/ShowMessageStanza
+++ b/share/html/Ticket/Elements/ShowMessageStanza
@@ -98,7 +98,7 @@ my $print_content = sub {
     $m->callback( content => $ref, %ARGS );
     $m->comp('/Elements/MakeClicky', content => $ref, ticket => $ticket, %ARGS);
     unless ( $plain_text_pre || $plain_text_mono ) {
-        $$ref =~ s{(?=\r*\n)}{<br />}g if defined $$ref;
+        $$ref =~ s{(\r?\n)}{<br />}g if defined $$ref;
     }
     $m->out( $$ref );
 };





More information about the rt-users mailing list