[rt-users] Text Attachements within HTML mails

[benoit plessis]

Hi,

We are experiencing some inconvenient with RT 3.8.8 and text attachements.

When a text only mail containing a text/plain attachment is replied
upon everything is fine and the attachment is not shown
in the reply message box, however, for text/html message the first
attached text/plain file is used, instead of the inlined text/plain
which is quite problematic when there is an 1Mb attached text file =>
FF hang during a long time :(


Also there is a small patch so that big text attachements, marked as
attachemnt are not marked as
"not shown because too large" but as "not shown because not inlined":

--- Ticket/Elements/ShowTransactionAttachments.org      2010-11-04
12:18:01.141242000 +0100
+++ Ticket/Elements/ShowTransactionAttachments  2010-11-04
12:18:16.057536000 +0100
@@ -154,7 +154,11 @@
    # If it's text
    if ( $message->ContentType =~ m{^(text|message)}i ) {
        my $max_size = RT->Config->Get( 'MaxInlineBody',
$session{'CurrentUser'} );
-        if ( $message->Filename &&
RT->Config->Get('SuppressInlineTextFiles', $session{'CurrentUser'} ) )
{
+        if ( $disposition ne 'inline' ) {
+            $m->out('<p>'. loc( 'Message body is not shown because
sender requested not to inline it.' ) .'</p>');
+            return;
+        }
+        elsif ( $message->Filename &&
RT->Config->Get('SuppressInlineTextFiles', $session{'CurrentUser'} ) )
{
            $m->out('<p>'. loc( 'Text file is not shown because it is
disabled in preferences.' ) .'</p>');
            return;
        }
@@ -162,10 +166,6 @@
            $m->out('<p>'. loc( 'Message body not shown because it is
too large.' ) .'</p>');
            return;
        }
-        elsif ( $disposition ne 'inline' ) {
-            $m->out('<p>'. loc( 'Message body is not shown because
sender requested not to inline it.' ) .'</p>');
-            return;
-        }

        if (