[rt-users] UseSQLForACLChecks performance problem on RT 3.8

[ktm at rice.edu]

Dear RT community,

While investigating performance issues caused by enabling the
option UseSQLForACLChecks, a big cause of the slowdown was drawing
the QuickSeach panel and its resulting DB queries. In RT4 they
have been consolidated into a single query. I have attached a
patched version of html/Elements/QueueSummary that does the same
for RT 3.8.x. The sample that was 15s before is now 2s.

Regards,
Ken
-------------- next part --------------
%# BEGIN BPS TAGGED BLOCK {{{
%#
%# COPYRIGHT:
%#
%# This software is Copyright (c) 1996-2013 Best Practical Solutions, LLC
%#                                          <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
%#
%#
%# LICENSE:
%#
%# This work is made available to you under the terms of Version 2 of
%# the GNU General Public License. A copy of that license should have
%# been provided with this software, but in any event can be snarfed
%# from www.gnu.org.
%#
%# This work is distributed in the hope that it will be useful, but
%# WITHOUT ANY WARRANTY; without even the implied warranty of
%# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
%# General Public License for more details.
%#
%# You should have received a copy of the GNU General Public License
%# along with this program; if not, write to the Free Software
%# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
%# 02110-1301 or visit their web page on the internet at
%# http://www.gnu.org/licenses/old-licenses/gpl-2.0.html.
%#
%#
%# CONTRIBUTION SUBMISSION POLICY:
%#
%# (The following paragraph is not intended to limit the rights granted
%# to you to modify and distribute this software under the terms of
%# the GNU General Public License and is only of importance to you if
%# you choose to contribute your changes and enhancements to the
%# community by submitting them to Best Practical Solutions, LLC.)
%#
%# By intentionally submitting any modifications, corrections or
%# derivatives to this work, or any other work intended for use with
%# Request Tracker, to Best Practical Solutions, LLC, you confirm that
%# you are the copyright holder for those contributions and you grant
%# Best Practical Solutions,  LLC a nonexclusive, worldwide, irrevocable,
%# royalty-free, perpetual, license to use, copy, create derivative
%# works based on those contributions, and sublicense and distribute
%# those contributions and any derivatives thereof.
%#
%# END BPS TAGGED BLOCK }}}
<table border="0" cellspacing="0" cellpadding="1" width="100%" class="queue-summary">

<tr>
    <th class="collection-as-table"><&|/l&>Queue</&></th>
% for my $status ( @statuses ) {
    <th class="collection-as-table"><% loc($status) %></th>
% }
</tr>

<%PERL>
my $i = 0;
for my $queue (@queues) {
    $i++;
    my $name = $queue->{Name};
    $name =~ s/(['\\])/\\$1/g;
    my $queue_cond = "Queue = '$name' AND ";
    my $all_q = $queue_cond . '('.join( " OR ", map "Status = '$_'", @statuses ) . ')';
</%PERL>
<tr class="<% $i%2 ? 'oddline' : 'evenline'%>" >

<td>
    <a href="<% RT->Config->Get('WebPath') %>/Search/Results.html?Query=<% $all_q |u,n %>" title="<% $queue->{Description} %>"><% $queue->{Name} %></a>
</td>

<%perl>
   for my $status (@statuses) {
</%perl>
<td align="right">
    <a href="<% RT->Config->Get('WebPath') %>/Search/Results.html?Query=<% $queue_cond ."Status = '$status'" |u,n %>"><% $data->{$queue->{id}}->{$status } || '-' %></a>
</td>
%   }
</tr>
% }
</table>
<%INIT>
# Ensure sane default
unless ( @statuses ) {
    foreach (RT::Queue->ActiveStatusArray()) {
        push @statuses, $_;
    }
}

my @queues;

if ($cache && exists $session{$cache}) {
    @queues = @{$session{$cache}};
} else {
    my $Queues = RT::Queues->new( $session{'CurrentUser'} );
    $Queues->UnLimit();
    $m->callback( CallbackName => 'SQLFilter', Queues => $Queues );

    @queues = grep $queue_filter->($_), @{ $Queues->ItemsArrayRef };
    $m->callback( CallbackName => 'Filter', Queues => \@queues );

    @queues = map {
        {  id          => $_->Id,
           Name        => $_->Name,
           Description => $_->Description || '',
        }
    } grep $_, @queues;

    $session{$cache} = \@queues if $cache;
}

my $data     = {};
my $statuses = {};

use RT::Report::Tickets;
my $report = RT::Report::Tickets->new( RT->SystemUser );
my $query =
    "(".
    join(" OR ", map {s{(['\\])}{\\$1}g; "Status = '$_'"} @statuses) #'
    .") AND (".
    join(' OR ', map "Queue = ".$_->{id}, @queues)
    .")";
$query = 'id < 0' unless @queues;
$report->SetupGroupings( Query => $query, GroupBy => [qw(Status Queue)] );

while ( my $entry = $report->Next ) {
    $data->{ $entry->__Value("Queue") }->{ $entry->__Value("Status") }
        = $entry->__Value('id');
    $statuses->{ $entry->__Value("Status") } = 1;
}
</%INIT>
<%ARGS>
$cache => undef
$queue_filter => undef
@statuses => ()
</%ARGS>