[rt-users] Hardcoded Bookmarked Ticked Rows to 999 by Ruz

[Kevin Falcone]

On Wed, May 08, 2013 at 06:56:25PM +0200, pavel.sidlo at linuxbox.cz wrote:
>    One user complained about broken "Rows per page" in "Bookmarken Tickets". After some searching
>    I found this commit in html/Elements/ShowSearch:
>    [1]https://github.com/bestpractical/rt/commit/00257eac62dd4955934d7350e5a3395e57e0069c#html/Elements/ShowSearch
> 
>    It contains hardcoded limit for Bookmarked tickets:
>        if ( $_->{'Query'} =~ /__Bookmarked__/ ) {
>            $_->{'Rows'} = 999;
>        }
>        elsif ( $_->{'Query'} =~ /__Bookmarks__/ ) {
>            $_->{'Rows'} = 999;
> 
>    Is it necessary for some functionality? Is it safe to remove this condition in local copy of
>    ShowSearch file?
> 

I suspect this dates from 3.8.0/3.8.1 when Bookmarks were presented as
a very custom search, rather than as "id = '__Bookmarked__'"

While the latter part should remain because it's more or less a dead
path, do you want to try out the following patch and see if it fixes
what your user is seeing? 

https://github.com/bestpractical/rt/commit/240a9e033394a6d95cb2af4ed6ee452b060ef165.patch

You'll want to clear your mason cache and restart apache after
applying.

-kevin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 235 bytes
Desc: not available
URL: <http://lists.bestpractical.com/pipermail/rt-users/attachments/20130528/222ff746/attachment.sig>