[SearchBuilder-devel] [RFC][PATCH] Pages fixes and tests for it functionality

Ruslan Zakirov ruslan.zakirov at gmail.com
Wed Jul 27 12:53:11 EDT 2005


On 7/27/05, Jesse Vincent <jesse at bestpractical.com> wrote:
> So,  the only thing that I'm not really sure about is starting with row
> zero, rather than row 1, at least from a first read of this code.
> 
> I'm willing to be swayed by an argument, though.
I don't mind against to start from 1 instead of zero for FirstRow, but
only if we do the same for GotoPage and GotoItem methods. Don't you
think that it's inconsistent?

> 
> At this point, do you want to see this in Jifty::DBI (aka the 2.0) or
> SB?
It was developed for SB to be backward compatible as much as possible,
but for SB2.0 this should be discussed and refactored. I can send
proposal with ideas and code how should page support looks like.

> 
> I'm sorry for the delay in my reply. This just got buried under another
> 950 messages.
IMHO you are not only person who's interested in this work and this
very sad nobody wrote a note.

> 
> Jesse
> 
> On Jun 9, 2005, at 10:47 PM, Ruslan U. Zakirov wrote:
> 
> > Require comments and review.
> > All tests pass for SQLite, MySQL and PostgreSQL.
> >
> >  r1777 at cubic-pc:  cubic | 2005-06-10 00:51:48 +0400
> >
> >  fix pages+count handling
> >  now count returns correct values
> >  some tests still fails because of GotoPage doesnt overlap like
> > NextPage
> >  need overview how nice it works
> >  r1778 at cubic-pc:  cubic | 2005-06-10 06:43:33 +0400
> >   new tests for pages support
> >  change FirstRow arg handling to consistent state with other indexies
> >
[snip]

-- 
Best regards, Ruslan.


More information about the SearchBuilder-devel mailing list