[SearchBuilder-devel] [RFC][PATCH] Pages fixes and tests for it functionality

[Ruslan Zakirov]

On 7/28/05, Jesse Vincent <jesse at bestpractical.com> wrote:
> 
> On Wed, Jul 27, 2005 at 08:53:11PM +0400, Ruslan Zakirov wrote:
> > On 7/27/05, Jesse Vincent <jesse at bestpractical.com> wrote:
> > > So,  the only thing that I'm not really sure about is starting with row
> > > zero, rather than row 1, at least from a first read of this code.
> > >
> > > I'm willing to be swayed by an argument, though.
> > I don't mind against to start from 1 instead of zero for FirstRow, but
> > only if we do the same for GotoPage and GotoItem methods. Don't you
> > think that it's inconsistent?
> 
> I agree that it's inconsistent. I think everything should start with 1.
> 
> Books don't have a page 0.
> Lists don't have an item 0.
Ok. So this is a plan for Jifty::DBI
For SB we should leave all as is: GotoPage and GotoItem work with 0,
but FirstRow works with 1. This would be backward compatible. I'll
update SB patch.

> 
> >
> > >
> > > At this point, do you want to see this in Jifty::DBI (aka the 2.0) or
> > > SB?
> > It was developed for SB to be backward compatible as much as possible,
> > but for SB2.0 this should be discussed and refactored. I can send
> > proposal with ideas and code how should page support looks like.
> 
> Ok. That would be cool. It might make sense to use Data::Page rather
> than doing it all ourselves.
Will send comments in other mail.

-- 
Best regards, Ruslan.