[SearchBuilder-devel] [PATCH] OrderBy changes

[Ruslan Zakirov]

On 11/2/05, Robert Spier <rspier at pobox.com> wrote:
>
>
> (Selective snipping)
>
> > +    my $clause = '';
> > +    foreach my $row ( @args ) {
> > +    $clause = "ORDER BY$clause" if $clause;
>
> Is $clause guaranteed to have whitespace at the beginning?
yes.

>
>
> > +    if( ($self->{'order_clause'} || '') ne $clause ) {
> > +     $self->RedoSearch();
>
> Indentation bad.
may be, sorry, wrong vim config.

> Also, IIRC, RT generally puts a space after the if.
ok. I don't mind any coding style, but only when it's defined and
all developers follow it.

>
> -R
> _______________________________________________
> SearchBuilder-devel mailing list
> SearchBuilder-devel at bestpractical.com
> http://lists.bestpractical.com/cgi-bin/mailman/listinfo/searchbuilder-devel
>


--
Best regards, Ruslan.