[SearchBuilder-devel] Re: [Rt-commit] r4057 - in Jifty-DBI/trunk: . lib/Jifty lib/Jifty/DBI lib/Jifty/DBI/Collection

[Ruslan Zakirov]

On 11/9/05, jesse at bestpractical.com <jesse at bestpractical.com> wrote:
> Author: jesse
> Date: Tue Nov  8 16:33:18 2005
> New Revision: 4057
>
[snip]
> ==============================================================================
> --- Jifty-DBI/trunk/lib/Jifty/DBI/Collection/Unique.pm  (original)
> +++ Jifty-DBI/trunk/lib/Jifty/DBI/Collection/Unique.pm  Tue Nov  8 16:33:18 2005
> @@ -1,11 +1,13 @@
>  package Jifty::DBI::Collection::Unique;
> +use strict;
> +use warnings;
> +
>  use base 'Exporter';
>  our @EXPORT  = qw(AddRecord);
you renamed the method, but imho classes shouldn't export anything.

>  our $VERSION = "0.01";
> -use strict;
> -use warnings;
>
> -sub AddRecord {
> +
> +sub add_record {
>      my $self   = shift;
>      my $record = shift;
>
>
> Modified: Jifty-DBI/trunk/lib/Jifty/DBI/Column.pm
> ==============================================================================
> --- Jifty-DBI/trunk/lib/Jifty/DBI/Column.pm     (original)
> +++ Jifty-DBI/trunk/lib/Jifty/DBI/Column.pm     Tue Nov  8 16:33:18 2005
> @@ -3,6 +3,7 @@
>
>  package Jifty::DBI::Column;
>
> +our $VERSION = '0.01';
IMHO per file versions lead to insanity and only useful when file can
be used without other files in distribution.

>  use base qw/Class::Accessor Jifty::DBI::HasFilters/;
>  use UNIVERSAL::require;
>
[snip]

--
Best regards, Ruslan.