[svk-commit] r2127 - in trunk/lib/SVK: .

[clkao at bestpractical.com]

Author: clkao
Date: Thu Nov  9 22:25:58 2006
New Revision: 2127

Modified:
   trunk/lib/SVK/Config.pm
   trunk/lib/SVK/Mirror/Backend/SVNRa.pm

Log:
Support win32 and keychain auth providers if available.

Modified: trunk/lib/SVK/Config.pm
==============================================================================
--- trunk/lib/SVK/Config.pm	(original)
+++ trunk/lib/SVK/Config.pm	Thu Nov  9 22:25:58 2006
@@ -8,10 +8,15 @@
 __PACKAGE__->mk_classdata('auth_providers');
 
 # XXX: this is 1.3 api. use SVN::Auth::* for 1.4 and we don't have to load ::Client anymore
+# (well, fix svn perl bindings to wrap the prompt functions correctly first.
 require SVN::Client;
 __PACKAGE__->auth_providers(
     sub {
+	my $keychain = SVN::_Core->can('svn_auth_get_keychain_simple_provider');
+	my $win32 = SVN::_Core->can('svn_auth_get_windows_simple_provider');
         [
+	    $keychain ? $keychain : (),
+	    $win32    ? $win32    : (),
             SVN::Client::get_simple_provider(),
             SVN::Client::get_ssl_server_trust_file_provider(),
             SVN::Client::get_username_provider(),

Modified: trunk/lib/SVK/Mirror/Backend/SVNRa.pm
==============================================================================
--- trunk/lib/SVK/Mirror/Backend/SVNRa.pm	(original)
+++ trunk/lib/SVK/Mirror/Backend/SVNRa.pm	Thu Nov  9 22:25:58 2006
@@ -232,6 +232,7 @@
         }
     }
     $self->_ra_finished($ra);
+    # FIXME: if we do ^c here $err would be empty. do something else.
     return $self->_has_replay(0)
       if $err->apr_err == $SVN::Error::RA_NOT_IMPLEMENTED      # ra_svn
       || $err->apr_err == $SVN::Error::UNSUPPORTED_FEATURE;    # ra_dav