[svk-commit] r2421 - branches/svk-logger/lib/SVK/Command

nobody at bestpractical.com nobody at bestpractical.com
Fri Jun 29 10:35:07 EDT 2007


Author: clsung
Date: Fri Jun 29 10:35:05 2007
New Revision: 2421

Modified:
   branches/svk-logger/lib/SVK/Command/Add.pm
   branches/svk-logger/lib/SVK/Command/Cleanup.pm
   branches/svk-logger/lib/SVK/Command/Depotmap.pm
   branches/svk-logger/lib/SVK/Command/Help.pm
   branches/svk-logger/lib/SVK/Command/Ignore.pm
   branches/svk-logger/lib/SVK/Command/Merge.pm
   branches/svk-logger/lib/SVK/Command/Mirror.pm
   branches/svk-logger/lib/SVK/Command/Verify.pm

Log:
- remove some redundant newline '\n'

Modified: branches/svk-logger/lib/SVK/Command/Add.pm
==============================================================================
--- branches/svk-logger/lib/SVK/Command/Add.pm	(original)
+++ branches/svk-logger/lib/SVK/Command/Add.pm	Fri Jun 29 10:35:05 2007
@@ -141,7 +141,7 @@
         $bin = ' - (bin)' if !mimetype_is_text( $newprop->{'svn:mime-type'} );
     }
 
-    $logger->info( "$st   $report$bin\n");
+    $logger->info( "$st   $report$bin");
 }
 
 1;

Modified: branches/svk-logger/lib/SVK/Command/Cleanup.pm
==============================================================================
--- branches/svk-logger/lib/SVK/Command/Cleanup.pm	(original)
+++ branches/svk-logger/lib/SVK/Command/Cleanup.pm	Fri Jun 29 10:35:05 2007
@@ -73,7 +73,7 @@
 
     if ($self->{all}) {
         $self->{xd}{checkout}->store ('', {lock => undef});
-        $logger->info( loc("Cleaned up all stalled locks.\n"));
+        $logger->info( loc("Cleaned up all stalled locks."));
         return;
     }
 

Modified: branches/svk-logger/lib/SVK/Command/Depotmap.pm
==============================================================================
--- branches/svk-logger/lib/SVK/Command/Depotmap.pm	(original)
+++ branches/svk-logger/lib/SVK/Command/Depotmap.pm	Fri Jun 29 10:35:05 2007
@@ -110,9 +110,9 @@
               get_buffer_from_editor( loc('depot map'), $sep, "$map\n$sep\n",
                 'depotmap' );
             $new = eval { YAML::Syck::Load($map) };
-            $logger->info("$@\n") if $@;
+            $logger->info("$@") if $@;
         } while ($@);
-        $logger->info( loc("New depot map saved.\n"));
+        $logger->info( loc("New depot map saved."));
         $self->{xd}{depotmap} = $new;
     }
     $self->{xd}->create_depots;
@@ -132,7 +132,7 @@
 
     $self->{xd}{depotmap}{$depot} = $path;
 
-    $logger->info(loc("New depot map saved.\n"));
+    $logger->info(loc("New depot map saved."));
     $self->{xd}->create_depots;
 }
 

Modified: branches/svk-logger/lib/SVK/Command/Help.pm
==============================================================================
--- branches/svk-logger/lib/SVK/Command/Help.pm	(original)
+++ branches/svk-logger/lib/SVK/Command/Help.pm	Fri Jun 29 10:35:05 2007
@@ -75,7 +75,7 @@
             my @cmd;
             my $dir = $INC{'SVK/Command.pm'};
             $dir =~ s/\.pm$//;
-            $logger->info( loc("Available commands:\n"));
+            $logger->info( loc("Available commands:"));
             find (
                 sub { push @cmd, $File::Find::name if m/\.pm$/ }, $dir,
             );

Modified: branches/svk-logger/lib/SVK/Command/Ignore.pm
==============================================================================
--- branches/svk-logger/lib/SVK/Command/Ignore.pm	(original)
+++ branches/svk-logger/lib/SVK/Command/Ignore.pm	Fri Jun 29 10:35:05 2007
@@ -86,7 +86,7 @@
 
     my $current_ignore_re = $self->{xd}->ignore($svn_ignore);
     if ($filename =~ m/$current_ignore_re/) {
-        $logger->info( "Already ignoring '$report'\n");
+        $logger->info( "Already ignoring '$report'");
     } else {
         $svn_ignore .= "\n"
           if length $svn_ignore and substr($svn_ignore, -1, 1) ne "\n";

Modified: branches/svk-logger/lib/SVK/Command/Merge.pm
==============================================================================
--- branches/svk-logger/lib/SVK/Command/Merge.pm	(original)
+++ branches/svk-logger/lib/SVK/Command/Merge.pm	Fri Jun 29 10:35:05 2007
@@ -189,7 +189,7 @@
 
     $merge->{notice_copy} = 1;
     if ($merge->{fromrev} == $merge->{src}->revision) {
-	$logger->info( loc ("Empty merge.\n"));
+	$logger->info( loc ("Empty merge."));
 	return;
     }
 
@@ -199,7 +199,7 @@
     if ($self->{incremental}) {
 	die loc ("Not possible to do incremental merge without a merge ticket.\n")
 	    if $self->{no_ticket};
-	$logger->info( loc ("-m ignored in incremental merge\n")) if $self->{message};
+	$logger->info( loc ("-m ignored in incremental merge")) if $self->{message};
 	my @rev;
 
         traverse_history (

Modified: branches/svk-logger/lib/SVK/Command/Mirror.pm
==============================================================================
--- branches/svk-logger/lib/SVK/Command/Mirror.pm	(original)
+++ branches/svk-logger/lib/SVK/Command/Mirror.pm	Fri Jun 29 10:35:05 2007
@@ -123,7 +123,7 @@
 
     $m->relocate($source, @options);
 
-    $logger->info( loc("Mirror relocated.\n"));
+    $logger->info( loc("Mirror relocated."));
     return;
 }
 
@@ -155,7 +155,7 @@
 
 sub run {
     my ($self, $target) = @_;
-    $logger->info( loc("nothing to upgrade\n"));
+    $logger->info( loc("nothing to upgrade"));
     return;
 }
 
@@ -215,7 +215,7 @@
 
     my $fmt = "%-${max_depot_path}s   %-s\n";
     $logger->info(sprintf $fmt, loc('Path'), loc('Source'));
-    $logger->info( '=' x ( $max_depot_path + $max_uri + 3 ), "\n");
+    $logger->info( '=' x ( $max_depot_path + $max_uri + 3 ));
 
     $logger->info(sprintf $fmt, @$_ )for @mirror_columns;
 
@@ -301,7 +301,7 @@
         propset => { direct  => 1, revprop => 1 },
     )->run($_ => $props->{$_}, $target) for sort grep {m/^sv[nm]/} keys %$props;
 
-    $logger->info( loc("Mirror state successfully recovered.\n"));
+    $logger->info( loc("Mirror state successfully recovered."));
     return;
 }
 

Modified: branches/svk-logger/lib/SVK/Command/Verify.pm
==============================================================================
--- branches/svk-logger/lib/SVK/Command/Verify.pm	(original)
+++ branches/svk-logger/lib/SVK/Command/Verify.pm	Fri Jun 29 10:35:05 2007
@@ -90,7 +90,7 @@
     my $sig = $fs->revision_prop ($chg, 'svk:signature');
     return _verify($target->depot, $sig, $chg)
 	if $sig;
-    $logger->info( "No signature found for change $chg at /$depot/.\n");
+    $logger->info( "No signature found for change $chg at /$depot/.");
     return;
 }
 
@@ -127,7 +127,7 @@
 
     if ($?) {
         warn "Self is $self";
-        $logger->info( "Can't verify signature\n");
+        $logger->info( "Can't verify signature");
 	$self->{fail} = 1;
 	return;
     }
@@ -142,14 +142,14 @@
 	my ($md5, $filename) = ($1, $2);
 	my $checksum = delete $self->{checksum}{"$path/$filename"};
 	if ($checksum ne $md5) {
-	    $logger->info( "checksum for $path/$filename mismatched: $checksum vs $md5\n");
+	    $logger->info( "checksum for $path/$filename mismatched: $checksum vs $md5");
 	    $self->{fail} = 1;
 	    return;
 	}
     }
     # unsigned change
     if (my @unsig = keys %{$self->{checksum}}) {
-	$logger->info("Checksum for changed path ".join (',', @unsig)." not signed.\n");
+	$logger->info("Checksum for changed path ".join (',', @unsig)." not signed.");
 	$self->{fail} = 1;
     }
 }


More information about the svk-commit mailing list