[svk-commit] r2848 - in trunk: lib/SVK/Command lib/SVK/Editor t

[nobody at bestpractical.com]

Author: jesse
Date: Fri May  9 14:51:16 2008
New Revision: 2848

Removed:
   trunk/lib/SVK/Editor/Sign.pm
   trunk/t/72sign.t
Modified:
   trunk/   (props changed)
   trunk/MANIFEST
   trunk/lib/SVK/Command/Commit.pm

Log:
 r30710 at 31b:  jesse | 2008-05-09 14:48:28 -0400
 * Remove support for generating changeset signatures, per discussion
   with nickm. (They don't guarantee what users think they do and 
   are more likely to lead to a false sense of security then any _actual_ 
   security


Modified: trunk/MANIFEST
==============================================================================
--- trunk/MANIFEST	(original)
+++ trunk/MANIFEST	Fri May  9 14:51:16 2008
@@ -84,7 +84,6 @@
 lib/SVK/Editor/Patch.pm
 lib/SVK/Editor/Rename.pm
 lib/SVK/Editor/Serialize.pm
-lib/SVK/Editor/Sign.pm
 lib/SVK/Editor/Status.pm
 lib/SVK/Editor/SubTree.pm
 lib/SVK/Editor/Tee.pm

Modified: trunk/lib/SVK/Command/Commit.pm
==============================================================================
--- trunk/lib/SVK/Command/Commit.pm	(original)
+++ trunk/lib/SVK/Command/Commit.pm	Fri May  9 14:51:16 2008
@@ -73,7 +73,6 @@
     ('m|message=s'    => 'message',
      'F|file=s'       => 'message_file',
      'C|check-only'   => 'check_only',
-     'S|sign'         => 'sign',
      'P|patch=s'      => 'patch',
      'import'         => 'import',
      'direct'         => 'direct',
@@ -270,25 +269,6 @@
 	}
     }
 
-    if ($self->{sign}) {
-	$editor = SVK::Editor::Sign->new
-	    ( _editor => [$editor],
-	      anchor => $target->universal->ukey );
-	my $post_handler = $cb{post_handler};
-	if (my $m = $cb{mirror}) {
-	    $$post_handler = sub {
-                $m->change_rev_prop( $_[0], 'svk:signature', $editor->{sig} );
-		1;
-	    }
-	}
-	else {
-	    my $fs = $target->repos->fs;
-	    $$post_handler = sub {
-		$fs->change_rev_prop($_[0], 'svk:signature', $editor->{sig});
-		1;
-	    }
-	}
-    }
 
     unless ($self->{check_only}) {
 	my $txn = $cb{txn};
@@ -682,7 +662,6 @@
  --encoding ENC         : treat -m/-F value as being in charset encoding ENC
  --template             : use the specified message as the template to edit
  -P [--patch] NAME      : instead of commit, save this change as a patch
- -S [--sign]            : sign this change
  -C [--check-only]      : try operation but make no changes
  -N [--non-recursive]   : operate on single directory only
  --set-revprop P=V      : set revision property on the commit