[svk-devel] Refactored log filters

[Michael Hendricks]

On Fri, Aug 04, 2006 at 11:17:56AM -0400, David Glasser wrote:
> This is great. I've really found log filters to be an awesome feature
> of SVK. (And folks who haven't seen the stats filter on CPAN (which I
> hadn't until yesterday) should really check it out.)

Thanks, I'm glad you like them.

> There's one thing that confuses me. It seems that there exists a
> pretty clear division between output and selection filters.  Things
> seem to break in odd ways (examples available on request :) ) if you
> throw an output filter into the --filter argument, or a selection
> filter (or for that matter a |) into the --output argument.  I don't
> *think* you can ever have a filter that's both.
> 
> Shall we just make SVK::Log::Filter::Output and
> SVK::Log::Filter::Selection subclasses, and enforce this?

Yes, I think we should.  The current behavior is confusing and sends
users searching for what went wrong.  Specific subclasses with a helpful
error message is a good solution.  Now let's see if I can finish it
before the weekend :-)

-- 
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.bestpractical.com/pipermail/svk-devel/attachments/20060804/307aaf15/attachment.pgp