[svk-devel] [Patch] svk user preferences

[Ruslan Zakirov]

On 8/16/06, David Glasser <glasser at mit.edu> wrote:
> On 8/16/06, Michael Hendricks <michael at ndrix.org> wrote:
> > I think the patch is good enough to commit, but since there's been some
> > discussion about the config file on the list, I thought it should go
> > here first.  Comments, etc welcome.
>
> Awesome, this'll be great!
>
> A few random comments:
another thing:
Use catfile() instead of catdir.

>
> * "command-switches" kind of implies that it only works for, well,
> switches.  Maybe "default-arguments" or something instead?
>
> * We probably want some sort of --without-defaults too, but that can
> be added later.
As I recall Getopt::Long support prefix 'no' for options. I wander if
it works with patch.

>
> * I'm still not sure if it's better to do auto-shellwords-splitting of
> the defaults or just use YAML array syntax... probably it's better the
> way you have it.
>
> * Dumb YAML question: why doesn't the file have to begin with ---?
>
> --dave
>
> --
> David Glasser | glasser at mit.edu | http://www.davidglasser.net/
> _______________________________________________
> svk-devel mailing list
> svk-devel at bestpractical.com
> http://lists.bestpractical.com/cgi-bin/mailman/listinfo/svk-devel
>


-- 
Best regards, Ruslan.