[svk-devel] [PATCH] giving $SVKROOT priority over .svk/

[Michael Hendricks]

On Thu, Feb 22, 2007 at 11:44:16PM +0100, Bernhard Weisshuhn wrote:
> On Thu, Feb 22, 2007 at 04:09:21PM -0500, Daniel Jacobowitz <drow at false.org> wrote:
> > On Thu, Feb 22, 2007 at 09:28:44PM +0100, Bernhard Weisshuhn wrote:
> > > currently svk looks for a directory named '.svk' first and only then
> > > checks for $ENV{SVKROOT}, which makes using $SVKROOT a lottery.

... snip ...

> > Maybe this is a problem when your $PWD is $HOME?  I don't remember why
> > find_dotsvk does not check for the floating file - there was some
> > reason but maybe it wasn't a good one.
>
> Please excuse the noise and bear with me, my next mail will another
> suspected bug, and I hope this does not turn out as a pilot error
> again :-)

Bernhard, the point you bring up is a good one.  Daniel referred to
find_dotsvk not checking for a "floating file".  At the root of each
floating checkout is a .svk directory that contains a file named
"floating".  The original find_dotsvk code checked for the existence of
this "floating" file to make sure that the .svk directory it found truly
belonged to a floating checkout.  This was intended to prevent just the
situation you mention.

The cost of checking for the floating file is roughly a couple stat
calls.  I can't think of any reason to remove it.  If nobody else
remembers, I'll be glad to add it back to the code.

-- 
Michael