[svk-devel] Re: All Commands releasing giant_lock to early

[Bernhard Weisshuhn]

On Fri, Feb 23, 2007 at 12:03:24AM +0100, Bernhard Weisshuhn <bkw at weisshuhn.de> wrote:

> 
> I think a check for $@ should be added to the condition of the
> giant_unlock(), so that the code does what the comment says, namely
> only release the lock if the eval failed, like so:
>     
>     $self->{xd}->giant_unlock if $@ && $self->{xd} && ref ($self) && !$self->{hold_giant};
> 
> At least my code works after I made that change. 

... ahem ... it doesn't :-(

I must have changed something else along the way which made my problem
go away, but now, with everything reverted but the change above, things
are back to non-working.

Sorry, I'll do some more digging.

regards,
  bkw