[svk-devel] [PATCH] Verbose commits (includes ? files in commitlog)

[David Kaufman]

Hi Shawn,

Sartak <sartak at gmail.com> wrote:
> On 6/5/07, Chia-Liang Kao <clkao at clkao.org> wrote:
>>> On 6/5/07, Sartak <sartak at gmail.com> wrote:
>>>> The commit handler totally ignores these ? files. Maybe in the
>>>> future I'll try making it so if you manually change the ? to A,
>>>> it'll transparently do an svk add for that file. We'll see!
>>>
>> I think perhaps this can even be the default behaviour, and also it's
>> arguably backward compatible.  What do people think?
>
> Originally I had the commit buffer look like this:
>
> === Targets to commit (you may delete items from it) ===
> M   /home/sartak/svk/playground/mastermind.pl
>
> === Unversioned files ===
> ?   aaa

I like this format, perhaps adding the parenthesized (what you do from 
here) to the ? header as well, e.g.:

=== Unversioned files (you may replace ? with A to add them) ===
?   aaa

> So in summary the options are:
> 1. leave the behavior as I wrote it
> 2. get rid of the -v flag and include unversioned files by default
> 3. add an empty line between commit targets and unversioned files
> 4. add a second header between commit targets and unversioned files
>
> I'll be happy no matter which way we go on this.
> My vote is #4.

Mine too!

And I also agree with CLK that it should be default behavior.

-dave